remove DuckDB::Appender#begin_row

- remove from tests
- remove from documents

Author: suketa

README.md

@@ -218,7 +218,6 @@ def append
       appender = con.appender('users')
 
       10000.times do
-        appender.begin_row
         appender.append(1)
         appender.append('Alice')
         appender.end_row

ext/duckdb/appender.c

@@ -117,7 +117,6 @@ static VALUE appender_error_message(VALUE self) {
  *   con.query('CREATE TABLE users (id INTEGER, name VARCHAR)')
  *   appender = con.appender('users')
  *   appender
- *     .begin_row
  *     .append_int32(1)
  *     .append_varchar('Alice')
  *     .end_row
@@ -144,7 +143,6 @@ static VALUE appender_end_row(VALUE self) {
  *   con.query('CREATE TABLE users (id INTEGER, active BOOLEAN)')
  *   appender = con.appender('users')
  *   appender
- *     .begin_row
  *     .append_int32(1)
  *     .append_bool(true)
  *     .end_row
@@ -175,7 +173,6 @@ static VALUE appender_append_bool(VALUE self, VALUE val) {
  *   con.query('CREATE TABLE users (id INTEGER, age TINYINT)')
  *   appender = con.appender('users')
  *   appender
- *     .begin_row
  *     .append_int32(1)
  *     .append_int8(20)
  *     .end_row
@@ -204,7 +201,6 @@ static VALUE appender_append_int8(VALUE self, VALUE val) {
  *   con.query('CREATE TABLE users (id INTEGER, age SMALLINT)')
  *   appender = con.appender('users')
  *   appender
- *     .begin_row
  *     .append_int32(1)
  *     .append_int16(20)
  *     .end_row
@@ -233,7 +229,6 @@ static VALUE appender_append_int16(VALUE self, VALUE val) {
  *   con.query('CREATE TABLE users (id INTEGER, age INTEGER)')
  *   appender = con.appender('users')
  *   appender
- *     .begin_row
  *     .append_int32(1)
  *     .append_int32(20)
  *     .end_row
@@ -262,7 +257,6 @@ static VALUE appender_append_int32(VALUE self, VALUE val) {
  *   con.query('CREATE TABLE users (id INTEGER, age BIGINT)')
  *   appender = con.appender('users')
  *   appender
- *     .begin_row
  *     .append_int32(1)
  *     .append_int64(20)
  *     .end_row

lib/duckdb/appender.rb

@@ -44,7 +44,6 @@ def begin_row
     #   con.query('CREATE TABLE users (id INTEGER, name VARCHAR)')
     #   appender = con.appender('users')
     #   appender
-    #     .begin_row
     #     .append_int32(1)
     #     .append_varchar('Alice')
     #     .end_row
@@ -63,7 +62,6 @@ def flush
     #   con.query('CREATE TABLE numbers (num HUGEINT)')
     #   appender = con.appender('numbers')
     #   appender
-    #     .begin_row
     #     .append_hugeint(-170_141_183_460_469_231_731_687_303_715_884_105_727)
     #     .end_row
     def append_hugeint(value)
@@ -79,7 +77,6 @@ def append_hugeint(value)
     #   con.query('CREATE TABLE numbers (num UHUGEINT)')
     #   appender = con.appender('numbers')
     #   appender
-    #     .begin_row
     #     .append_hugeint(340_282_366_920_938_463_463_374_607_431_768_211_455)
     #     .end_row
     def append_uhugeint(value)
@@ -94,7 +91,6 @@ def append_uhugeint(value)
     #   con = db.connect
     #   con.query('CREATE TABLE dates (date_value DATE)')
     #   appender = con.appender('dates')
-    #   appender.begin_row
     #   appender.append_date(Date.today)
     #   # or
     #   # appender.append_date(Time.now)
@@ -114,7 +110,6 @@ def append_date(value)
     #   con = db.connect
     #   con.query('CREATE TABLE times (time_value TIME)')
     #   appender = con.appender('times')
-    #   appender.begin_row
     #   appender.append_time(Time.now)
     #   # or
     #   # appender.append_time('01:01:01')
@@ -133,7 +128,6 @@ def append_time(value)
     #   con = db.connect
     #   con.query('CREATE TABLE timestamps (timestamp_value TIMESTAMP)')
     #   appender = con.appender('timestamps')
-    #   appender.begin_row
     #   appender.append_time(Time.now)
     #   # or
     #   # appender.append_time(Date.today)
@@ -156,7 +150,6 @@ def append_timestamp(value)
     #   con.query('CREATE TABLE intervals (interval_value INTERVAL)')
     #   appender = con.appender('intervals')
     #   appender
-    #     .begin_row
     #     .append_interval('P1Y2D') # => append 1 year 2 days interval.
     #     .end_row
     #     .flush
@@ -172,7 +165,6 @@ def append_interval(value)
     #   con = db.connect
     #   con.query('CREATE TABLE users (id INTEGER, name VARCHAR)')
     #   appender = con.appender('users')
-    #   appender.begin_row
     #   appender.append(1)
     #   appender.append('Alice')
     #   appender.end_row
@@ -214,12 +206,10 @@ def append(value)
     #
     # is same as:
     #
-    #   appender.begin_row
-    #   appender.append(1)
+    #   appender.append(2)
     #   appender.append('Alice')
     #   appender.end_row
     def append_row(*args)
-      begin_row
       args.each do |arg|
         append(arg)
       end

lib/duckdb/interval.rb

@@ -24,7 +24,6 @@ module DuckDB
   #   con.query('CREATE TABLE intervals (interval_value INTERVAL)')
   #   appender = con.appender('intervals')
   #   appender
-  #     .begin_row
   #     .append_interval(interval)
   #     .end_row
   #     .flush

test/duckdb_test/appender_test.rb

@@ -51,7 +51,6 @@ def test_s_new_with_schema
 
     def sub_test_append_column2(method, type, values:, expected:)
       create_appender("col #{type}")
-      @appender.begin_row
       @appender.send(method, *values)
       @appender.end_row
       @appender.flush
@@ -72,8 +71,6 @@ def sub_assert_equal(expected, actual)
     def assert_duckdb_appender(expected, type, &block)
       create_appender("col #{type}")
 
-      @appender.begin_row
-
       block.call(@appender) if block_given?
 
       @appender.end_row
@@ -88,10 +85,14 @@ def assert_duckdb_appender(expected, type, &block)
       teardown
     end
 
+    def test_begin_row
+      appender = create_appender('col BOOLEAN')
+      assert_equal(appender.__id__, appender.begin_row.__id__)
+    end
+
     def test_flush
       appender = create_appender('col BOOLEAN')
       appender
-        .begin_row
         .append_bool(true)
         .end_row
       assert_equal(appender.__id__, appender.flush.__id__)
@@ -100,7 +101,6 @@ def test_flush
     def test_flush_with_exception
       appender = create_appender('col BOOLEAN NOT NULL')
       appender
-        .begin_row
         .append_null
         .end_row
       exception = assert_raises(DuckDB::Error) { appender.flush }