Skip to content

Commit 5de9a8e

Browse files
add sulu 3.0 support
1 parent b01a156 commit 5de9a8e

File tree

6 files changed

+42
-310
lines changed

6 files changed

+42
-310
lines changed

Controller/FormWebsiteController.php

Lines changed: 0 additions & 248 deletions
This file was deleted.

DependencyInjection/SuluFormExtension.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,6 @@ public function load(array $configs, ContainerBuilder $container): void
228228
}
229229

230230
if (SuluKernel::CONTEXT_WEBSITE === $container->getParameter('sulu.context')) {
231-
$container->setAlias(FormWebsiteController::class, 'sulu_form.form_website_controller')
232-
->setPublic(true);
233231
$container->setAlias(FormTokenController::class, 'sulu_form.form_token_controller')
234232
->setPublic(true);
235233
}

Metadata/DynamicFormMetadataLoader.php

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace Sulu\Bundle\FormBundle\Metadata;
1313

1414
use Sulu\Bundle\AdminBundle\FormMetadata\FormMetadataMapper;
15-
use Sulu\Bundle\AdminBundle\FormMetadata\FormXmlLoader;
15+
use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\Loader\FormXmlLoader;
1616
use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\FieldMetadata;
1717
use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\FormMetadata;
1818
use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\FormMetadataLoaderInterface;
@@ -45,6 +45,8 @@ class DynamicFormMetadataLoader implements FormMetadataLoaderInterface, CacheWar
4545

4646
/**
4747
* @var FormMetadataMapper
48+
*
49+
* TODO REMOVE
4850
*/
4951
private $formMetadataMapper;
5052

@@ -90,7 +92,7 @@ public function warmUp($cacheDir, ?string $buildDir = null): array
9092
$formMetadataCollection = $this->formXmlLoader->load($resource);
9193
foreach ($formMetadataCollection->getItems() as $locale => $formMetadata) {
9294
$section = new SectionMetadata('formFields');
93-
$section->setLabel($this->translator->trans('sulu_form.form_fields', [], 'admin', $locale));
95+
$section->setLabel($this->translator->trans('sulu_form.form_fields', [], 'admin', $locale), $locale);
9496
$fields = new FieldMetadata('fields');
9597
$fields->setType('block');
9698

@@ -101,8 +103,8 @@ public function warmUp($cacheDir, ?string $buildDir = null): array
101103
$fieldTypeMetaDataCollection[] = $this->loadFieldTypeMetadata($typeKey, $type, $locale);
102104
}
103105

104-
\usort($fieldTypeMetaDataCollection, static function(FormMetadata $a, FormMetadata $b): int {
105-
return \strcmp($a->getTitle(), $b->getTitle());
106+
\usort($fieldTypeMetaDataCollection, static function(FormMetadata $a, FormMetadata $b)use($locale): int {
107+
return \strcmp($a->getTitle($locale), $b->getTitle($locale));
106108
});
107109

108110
foreach ($fieldTypeMetaDataCollection as $fieldTypeMetaData) {
@@ -111,11 +113,13 @@ public function warmUp($cacheDir, ?string $buildDir = null): array
111113

112114
$fields->setDefaultType(\current($fields->getTypes())->getName());
113115
$section->addItem($fields);
116+
/* TODO HOW?
114117
$formItems = $formMetadata->getItems();
115118
$this->arrayInsertAtPosition($formItems, 1, [$section->getName() => $section]);
116119
$formMetadata->setItems($formItems);
117120
$configCache = $this->getConfigCache($formMetadata->getKey(), $locale);
118121
$configCache->write(\serialize($formMetadata), [new FileResource($resource)]);
122+
*/
119123
}
120124

121125
return [];
@@ -151,11 +155,12 @@ private function loadFieldTypeMetadata(string $typeKey, FormFieldTypeInterface $
151155
{
152156
$form = new FormMetadata();
153157
$configuration = $type->getConfiguration();
158+
154159
$properties = $this->propertiesXmlLoader->load($configuration->getXmlPath());
155160

156-
$form->setItems($this->formMetadataMapper->mapChildren($properties->getProperties(), $locale));
157-
$form->setName($typeKey);
158-
$form->setTitle($this->translator->trans($configuration->getTitle(), [], 'admin', $locale));
161+
$form->setItems($properties);
162+
$form->setKey($typeKey);
163+
$form->setTitle($this->translator->trans($configuration->getTitle(), [], 'admin', $locale), $locale);
159164

160165
return $form;
161166
}

Metadata/PropertiesXmlLoader.php

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111

1212
namespace Sulu\Bundle\FormBundle\Metadata;
1313

14-
use Sulu\Component\Content\Metadata\Loader\AbstractLoader;
15-
use Sulu\Component\Content\Metadata\Parser\PropertiesXmlParser;
14+
use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\Loader\AbstractLoader;
15+
use Sulu\Bundle\AdminBundle\Metadata\FormMetadata\Parser\PropertiesXmlParser;
1616
use Sulu\Component\Content\Metadata\PropertiesMetadata;
1717

1818
class PropertiesXmlLoader extends AbstractLoader
@@ -40,25 +40,17 @@ public function __construct(
4040
* @param string $resource
4141
* @param string $type
4242
*/
43-
protected function parse($resource, \DOMXPath $xpath, $type): PropertiesMetadata
43+
protected function parse($resource, \DOMXPath $xpath, $type): array
4444
{
45-
$tags = [];
46-
4745
$propertiesMetadata = new PropertiesMetadata();
4846
$propertiesMetadata->setResource($resource);
4947

5048
$propertiesNode = $xpath->query('/x:properties')->item(0);
5149
$properties = $this->propertiesXmlParser->load(
52-
$tags,
5350
$xpath,
54-
$propertiesNode
51+
$propertiesNode,
5552
);
5653

57-
foreach ($properties as $property) {
58-
$propertiesMetadata->addChild($property);
59-
}
60-
$propertiesMetadata->burnProperties();
61-
62-
return $propertiesMetadata;
54+
return $properties;
6355
}
6456
}

Resources/config/services.xml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@
174174
id="sulu_form.metadata.properties_xml_loader"
175175
class="Sulu\Bundle\FormBundle\Metadata\PropertiesXmlLoader"
176176
>
177-
<argument type="service" id="sulu_page.structure.properties_xml_parser"/>
177+
<argument type="service" id="sulu_admin.properties_xml_parser"/>
178178
</service>
179179

180180
<!-- Dynamic Form Metadata Loader -->
@@ -226,19 +226,6 @@
226226
<tag name="sulu.context" context="admin"/>
227227
</service>
228228

229-
<!-- Form Website Controller -->
230-
<service id="sulu_form.form_website_controller"
231-
class="Sulu\Bundle\FormBundle\Controller\FormWebsiteController"
232-
public="true">
233-
<tag name="container.service_subscriber" />
234-
<tag name="controller.service_arguments" />
235-
<tag name="sulu.context" context="website"/>
236-
237-
<call method="setContainer">
238-
<argument type="service" id="Psr\Container\ContainerInterface" />
239-
</call>
240-
</service>
241-
242229
<!-- Form Website Controller -->
243230
<service id="sulu_form.form_token_controller"
244231
class="Sulu\Bundle\FormBundle\Controller\FormTokenController"

0 commit comments

Comments
 (0)