Fix media url in data tab

Author: martinlagler

ListBuilder/DynamicListBuilder.php

@@ -51,7 +51,7 @@ public function build(Dynamic $dynamic, string $locale): array
 
         foreach ($entry as $key => $value) {
             if (Dynamic::TYPE_ATTACHMENT === $dynamic->getFieldType($key)) {
-                $singleEntry[$key] = $this->getMediaUrls($value);
+                $singleEntry[$key] = $this->getMediaUrls($value, $locale);
             } else {
                 $singleEntry[$key] = $this->toString($value);
             }
@@ -95,15 +95,15 @@ private function toString($value): string
     /**
      * @param mixed $value
      */
-    private function getMediaUrls($value): string
+    private function getMediaUrls($value, $locale): string
     {
         if (\is_string($value)) {
             return $this->getMediaUrl($value);
         }
 
         if (\is_array($value)) {
             foreach ($value as $key => $mediaId) {
-                $value[$key] = $this->getMediaUrl($mediaId);
+                $value[$key] = $this->getMediaUrl($mediaId, $locale);
             }
 
             return \implode($this->delimiter, $value);
@@ -112,30 +112,13 @@ private function getMediaUrls($value): string
         return $this->toString($value);
     }
 
-    private function getMediaUrl(string $value): string
+    private function getMediaUrl(string $value, string $locale): string
     {
-        return \str_replace('{id}', $value, $this->getDownloadUrl());
-    }
-
-    /**
-     * For performance generate route only once.
-     */
-    private function getDownloadUrl(): string
-    {
-        if (null === $this->downloadUrl) {
-            // The given id must be a number which we replace
-            $idReplacerNumber = '875421';
-
-            $this->downloadUrl = \str_replace($idReplacerNumber, '{id}', $this->router->generate(
-                'sulu_media.website.media.download',
-                [
-                    'slug' => 'file',
-                    'id' => $idReplacerNumber,
-                ],
-                RouterInterface::ABSOLUTE_URL
-            ));
-        }
-
-        return $this->downloadUrl;
+        return $this->router->generate('sulu_media.redirect', [
+            'id' => $value,
+            'locale' => $locale,
+        ],
+            RouterInterface::ABSOLUTE_URL
+        );
     }
 }