Fix issue with analyzedMediaUrl throws Exception (#403)

Author: alexander-schranz

Event/ProtectedMediaSubscriber.php

@@ -95,8 +95,12 @@ public function onRequest(RequestEvent $event): void
                 return;
             }
 
-            $mediaProperties = $this->formatCache->analyzedMediaUrl($request->getPathInfo());
-            $mediaId = $mediaProperties['id'];
+            try {
+                $mediaProperties = $this->formatCache->analyzedMediaUrl($request->getPathInfo());
+                $mediaId = $mediaProperties['id'];
+            } catch (\Exception $e) { // @phpstan-ignore-line // it is not the listeners responsibility to handle exceptions its later done by the controller
+                return;
+            }
         }
 
         if (!$mediaId) {

Tests/Unit/Event/ProtectedMediaSubscriberTest.php

@@ -19,6 +19,7 @@
 use Prophecy\Prophecy\ObjectProphecy;
 use Sulu\Bundle\FormBundle\Event\ProtectedMediaSubscriber;
 use Sulu\Bundle\FormBundle\Tests\Application\Kernel;
+use Sulu\Bundle\MediaBundle\Media\Exception\ImageProxyInvalidUrl;
 use Sulu\Bundle\MediaBundle\Media\FormatCache\FormatCacheInterface;
 use Sulu\Component\HttpKernel\SuluKernel;
 use Symfony\Component\HttpFoundation\RedirectResponse;
@@ -131,6 +132,28 @@ public function testImageProxyRoute(): void
         $this->protectedMediaSubscriber->onRequest($event);
     }
 
+    public function testAnalyzedMediaUrlThrowException(): void
+    {
+        $request = new Request();
+        $request->attributes->set('_route', 'sulu_media.website.image.proxy');
+        $request->server->set('REQUEST_URI', '/uploads/media/50x50/2-test-image.jpg');
+        $request->attributes->set('slug', '/50x50/2-test-image.jpg');
+
+        $event = new RequestEvent(
+            new Kernel('test', true, SuluKernel::CONTEXT_WEBSITE),
+            $request,
+            \defined(HttpKernelInterface::class . '::MASTER_REQUEST')
+                ? HttpKernelInterface::MASTER_REQUEST
+                : HttpKernelInterface::MAIN_REQUEST
+        );
+
+        $this->formatCache->analyzedMediaUrl(Argument::any())
+            ->willThrow(new ImageProxyInvalidUrl('some error'))
+            ->shouldBeCalled();
+
+        $this->assertNull($this->protectedMediaSubscriber->onRequest($event));
+    }
+
     public function testDownloadRoute(): void
     {
         $request = new Request();