free parsed themes to not show as mem leak

Author: kjk

src/GlobalPrefs.cpp

@@ -144,3 +144,10 @@ void SetFileStatePath(FileState* fs, const WCHAR* path) {
 Themes* ParseThemes(const char* data) {
     return (Themes*)DeserializeStruct(&gThemesInfo, data);
 }
+
+void FreeParsedThemes(Themes* themes) {
+    if (!themes) {
+        return;
+    }
+    FreeStruct(&gThemesInfo, themes);
+}

src/GlobalPrefs.h

@@ -23,5 +23,6 @@ void SetFileStatePath(FileState* fs, const char* path);
 // void SetFileStatePath(FileState* fs, const WCHAR* path);
 
 Themes* ParseThemes(const char* data);
+void FreeParsedThemes(Themes* themes);
 
 #define GetPrefsColor(name) GetParsedColor(name, name##Parsed)

src/SumatraStartup.cpp

@@ -1469,6 +1469,7 @@ int APIENTRY WinMain(_In_ HINSTANCE hInstance, _In_opt_ HINSTANCE, _In_ LPSTR, _
     ShutdownCleanup();
     EngineEbookCleanup();
     FreeCustomCommands();
+    FreeThemes();
 
     // it's still possible to crash after this (destructors of static classes,
     // atexit() code etc.) point, but it's very unlikely

src/Theme.cpp

@@ -146,16 +146,25 @@ static int gThemeCount;
 static int gCurrThemeIndex = 0;
 static Theme* gCurrentTheme = nullptr;
 static Theme* gThemeLight = nullptr;
+static Themes* gParsedThemes = nullptr;
 
 bool IsCurrentThemeDefault() {
     return gCurrThemeIndex == 0;
 }
 
+void FreeThemes() {
+    delete gThemes; // no need to free members, they are owned by gParsedThemes
+    gThemes = nullptr;
+    FreeParsedThemes(gParsedThemes);
+    gParsedThemes = nullptr;
+}
+
 void CreateThemeCommands() {
-    delete gThemes;
+    FreeThemes();
+
     gThemes = new Vec<Theme*>();
-    auto themes = ParseThemes(themesTxt);
-    for (Theme* theme : *themes->themes) {
+    gParsedThemes = ParseThemes(themesTxt);
+    for (Theme* theme : *gParsedThemes->themes) {
         gThemes->Append(theme);
     }
 

src/Theme.h

@@ -21,6 +21,7 @@ COLORREF ThemeNotificationsHighlightTextColor();
 COLORREF ThemeNotificationsProgressColor();
 bool ThemeColorizeControls();
 bool IsCurrentThemeDefault();
+void FreeThemes();
 
 extern int gFirstSetThemeCmdId;
 extern int gLastSetThemeCmdId;