feat(codegen): handle shared schemas

Author: matoous

codegen/Makefile

@@ -6,11 +6,15 @@ help: ## Show help
 
 .PHONY: fmt
 fmt: ## Format go files
-	golangci-lint fmt -v
+	golangci-lint fmt --verbose
 
 .PHONY: lint
 lint: ## Lint go files
-	golangci-lint run -v
+	golangci-lint run --verbose
+
+.PHONY: lint-fix
+lint-fix: ## Lint go files and apply auto-fixes
+	golangci-lint run --verbose --fix
 
 .PHONY: test
 test: ## Run tests

codegen/pkg/builder/collect.go

@@ -132,7 +132,7 @@ func (b *Builder) collectSchemas() {
 					c.collectSchemasInResponse(op)
 					c.collectSchemasInParams(op)
 					c.collectSchemasInRequest(op)
-					
+
 					for _, schema := range c {
 						if schema.GetReference() == schemaRef {
 							foundSchema = schema
@@ -147,7 +147,7 @@ func (b *Builder) collectSchemas() {
 					break
 				}
 			}
-			
+
 			if foundSchema != nil && !slices.ContainsFunc(schemasByTag["_shared"], func(sp *base.SchemaProxy) bool {
 				return sp.GetReference() == schemaRef
 			}) {
@@ -159,6 +159,13 @@ func (b *Builder) collectSchemas() {
 		}
 	}
 
+	// Sort shared schemas to ensure deterministic order
+	if sharedSchemas, ok := schemasByTag["_shared"]; ok {
+		slices.SortFunc(sharedSchemas, func(a, b *base.SchemaProxy) int {
+			return strings.Compare(a.GetReference(), b.GetReference())
+		})
+	}
+
 	b.schemasByTag = schemasByTag
 }
 

codegen/pkg/builder/out.go

@@ -255,12 +255,7 @@ func (b *Builder) generateResource(tagName string, paths *v3.Paths) error {
 }
 
 func usesSecretType(writables []Writable) bool {
-	for _, w := range writables {
-		if writableUsesSecret(w) {
-			return true
-		}
-	}
-	return false
+	return slices.ContainsFunc(writables, writableUsesSecret)
 }
 
 func writableUsesSecret(w Writable) bool {
@@ -288,19 +283,15 @@ func (b *Builder) usesSharedTypes(writables []Writable, methods []*Method) (bool
 	}
 
 	// Check writables for _shared references
-	for _, w := range writables {
-		if containsSharedRef(w) {
-			return true, "from .. import _shared"
-		}
+	if slices.ContainsFunc(writables, containsSharedRef) {
+		return true, "from .. import _shared"
 	}
 
 	// Check methods for _shared references (only if methods are provided)
-	if methods != nil {
-		for _, m := range methods {
-			for _, r := range m.Responses {
-				if r.Type != "" && strings.Contains(r.Type, "_shared.") {
-					return true, "from .. import _shared"
-				}
+	for _, m := range methods {
+		for _, r := range m.Responses {
+			if r.Type != "" && strings.Contains(r.Type, "_shared.") {
+				return true, "from .. import _shared"
 			}
 		}
 	}