Skip to content

Commit 4961ca7

Browse files
committed
remove wavelength
1 parent 03d95e3 commit 4961ca7

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

optika/materials/_snells_law.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,20 +39,17 @@ def snells_law_scalar(
3939

4040

4141
def snells_law(
42-
wavelength: u.Quantity | na.AbstractScalar,
4342
direction: na.AbstractCartesian3dVectorArray,
4443
index_refraction: float | na.AbstractScalar,
4544
index_refraction_new: float | na.AbstractScalar,
46-
normal: None | na.AbstractCartesian3dVectorArray,
45+
normal: None | na.AbstractCartesian3dVectorArray = None,
4746
is_mirror: bool | na.AbstractScalar = False,
4847
) -> na.Cartesian3dVectorArray:
4948
r"""
5049
A `vector form of Snell's law <https://en.wikipedia.org/wiki/Snell%27s_law#Vector_form>`_.
5150
5251
Parameters
5352
----------
54-
wavelength
55-
The wavelength of the incoming light
5653
direction
5754
The propagation direction of the incoming light
5855
index_refraction
@@ -91,7 +88,6 @@ def snells_law(
9188
# Define the keyword arguments that are common
9289
# to both the reflected and transmitted ray
9390
kwargs = dict(
94-
wavelength=350 * u.nm,
9591
direction=direction,
9692
index_refraction=1,
9793
normal=na.Cartesian3dVectorArray(0, 0, 1),

optika/materials/_tests/test_snells_law.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,6 @@ def test_snells_law_scalar(
4646
assert np.allclose(result, result_expected)
4747

4848

49-
@pytest.mark.parametrize(
50-
argnames="wavelength",
51-
argvalues=[
52-
350 * u.nm,
53-
na.linspace(300 * u.nm, 400 * u.nm, axis="wavelength", num=3),
54-
],
55-
)
5649
@pytest.mark.parametrize(
5750
argnames="direction",
5851
argvalues=[
@@ -87,15 +80,13 @@ def test_snells_law_scalar(
8780
],
8881
)
8982
def test_snells_law(
90-
wavelength: u.Quantity | na.AbstractScalar,
9183
direction: na.AbstractCartesian3dVectorArray,
9284
index_refraction: float | na.AbstractScalar,
9385
index_refraction_new: float | na.AbstractScalar,
9486
normal: None | na.AbstractCartesian3dVectorArray,
9587
is_mirror: bool | na.AbstractScalar,
9688
):
9789
result = optika.materials.snells_law(
98-
wavelength=wavelength,
9990
direction=direction,
10091
index_refraction=index_refraction,
10192
index_refraction_new=index_refraction_new,

optika/surfaces.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ def propagate_rays(
163163
wavelength_2 = wavelength_1 / r
164164

165165
b = optika.materials.snells_law(
166-
wavelength=wavelength_1,
167166
direction=a,
168167
index_refraction=n1,
169168
index_refraction_new=n2,

0 commit comments

Comments
 (0)