Commit 4cac691
authored
revert avro timestamp-millis mapping (apache#2223)
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to apache#2173, the conversion as implemented is not safe since
iceberg does not natively have `millis` precision. Timestamp values are
implicitly in `micros` precision
This is confirmed by
apache#2173 (comment)
Let's revert for now and follow up to figure out the right way to
support `millis` precision.
# Are these changes tested?
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->1 parent 63a37b1 commit 4cac691
File tree
2 files changed
+0
-7
lines changed- pyiceberg/utils
- tests/utils
2 files changed
+0
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
73 | 72 | | |
74 | 73 | | |
75 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
341 | 341 | | |
342 | 342 | | |
343 | 343 | | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | 344 | | |
351 | 345 | | |
352 | 346 | | |
| |||
0 commit comments