Skip to content

Commit 9c2c495

Browse files
committed
fix crash when firing a GraphQL with an invalid variable JSON
1 parent 0bfd80e commit 9c2c495

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ _Changes since 1.7.3_
2222

2323
### Fixed
2424
- Crash when selecting the last tab of a HTTP request then switching to a gRPC or WS request
25+
- Crash when firing a GraphQL with an invalid variable JSON
2526

2627
### Optimized
2728
- The app is minified. The app size is decreased by about 1/3.

src/jvmMain/kotlin/com/sunnychung/application/multiplatform/hellohttp/ux/AppView.kt

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -529,14 +529,18 @@ fun AppContentView() {
529529
val requestEditorModifier = Modifier.fillMaxWidth()
530530
request?.let { requestNonNull ->
531531
fun onClickSendOrConnect() {
532-
networkClientManager.fireRequest(
533-
request = requestNonNull,
534-
requestExampleId = selectedRequestExampleId!!,
535-
environment = selectedEnvironment,
536-
projectId = selectedProject!!.id,
537-
subprojectId = selectedSubproject!!.id,
538-
subprojectConfig = selectedSubproject.configuration.copy(),
539-
)
532+
try {
533+
networkClientManager.fireRequest(
534+
request = requestNonNull,
535+
requestExampleId = selectedRequestExampleId!!,
536+
environment = selectedEnvironment,
537+
projectId = selectedProject!!.id,
538+
subprojectId = selectedSubproject!!.id,
539+
subprojectConfig = selectedSubproject.configuration.copy(),
540+
)
541+
} catch (e: Throwable) {
542+
errorMessageVM.showErrorMessage(e.message ?: e.javaClass.name)
543+
}
540544
}
541545

542546
RequestEditorView(

0 commit comments

Comments
 (0)