use different operator for units on xray lines (#171)

* use different operator for units on xray lines

* changelog formatting

* update gwcs to fix CI run

Author: settwi

changelog/171.bugfix.rst

@@ -0,0 +1 @@
+Fixes bug which caused energy units to get squared; update the way units are assigned in `~sunkit_spex.legacy.thermal.thermal_emission`.

pyproject.toml

@@ -29,7 +29,7 @@ dependencies = [
     "scipy>=1.11",
     "sunpy>=6.0",
     "xarray>=2022.10",
-    "gwcs>=0.19",
+    "gwcs>=0.21.0",
     "ndcube>=2.1",
 ]
 

sunkit_spex/legacy/thermal.py

@@ -154,7 +154,7 @@ def setup_line_parameters(filename=None):
         "It (and its unit) therefore must be multiplied by emission measure and "
         "divided by 4 * pi * observer_distance**2 to get observed values."
     )
-    line_grid["line peaks keV"] = (line_info.peak_energy.data * line_info.attrs["units"]["peak_energy"]).to_value(
+    line_grid["line peaks keV"] = (line_info.peak_energy.data << line_info.attrs["units"]["peak_energy"]).to_value(
         u.keV, equivalencies=u.spectral()
     )
     line_grid["log10T"] = line_info.logT.data

sunkit_spex/models/physical/thermal.py

@@ -158,7 +158,7 @@ def setup_line_parameters(filename=None):
         "It (and its unit) therefore must be multiplied by emission measure and "
         "divided by 4 * pi * observer_distance**2 to get observed values."
     )
-    line_grid["line peaks keV"] = (line_info.peak_energy.data * line_info.attrs["units"]["peak_energy"]).to_value(
+    line_grid["line peaks keV"] = (line_info.peak_energy.data << line_info.attrs["units"]["peak_energy"]).to_value(
         u.keV, equivalencies=u.spectral()
     )
     line_grid["log10T"] = line_info.logT.data