feature: streamline banner data processing by removing redundant API calls

Author: sunrayyourdev

script.js

@@ -1275,54 +1275,35 @@ let banners = {
 }
 
 window.addEventListener('load', function() {
-    fetch('https://genshinlist.com/api/characters')
-        .then(response => response.json())
-        .then(data => {
-            characters = data;
-            console.log('Character data:', characters);
-            fetch('https://genshinlist.com/api/weapons')
-                .then(response => response.json())
-                .then(data => {
-                    weapons = data;
-                    console.log('Weapons data:', weapons);
-                    banners.standard.fiveStars = characters.filter((c) => {
-                            return c.rarity == 5 && !['Venti', 'Klee', 'Xiao', 'Tartaglia', 'Zhongli'].includes(c.name);
-                        }).concat(weapons.filter((c) => {
-                            return c.rarity == 5;
-                        }));
-                    banners.standard.fourStars = characters.filter((c) => {
-                            return c.rarity == 4;
-                        }).concat(weapons.filter((c) => {
-                            return c.rarity == 4;
-                        }));
-                    banners.standard.threeStars = weapons.filter((c) => {
-                            return c.rarity == 3;
-                        });
-                    banners.venti.featured.fiveStar = characters.filter((c) => {
-                            return c.name == 'Venti';
-                        });
-                    banners.venti.featured.fourStars = characters.filter((c) => {
-                            return c.rarity == 4 && ['Fischl', 'Sucrose', 'Xiangling'].includes(c.name);
-                        });
-                    banners.venti.regular.fiveStars = characters.filter((c) => {
-                            return c.rarity == 5 && !['Venti', 'Klee', 'Xiao', 'Tartaglia', 'Zhongli'].includes(c.name);
-                        });
-                    banners.venti.regular.fourStars = characters.filter((c) => {
-                            return c.rarity == 4 && !['Kaeya', 'Lisa', 'Amber', 'Fischl', 'Sucrose', 'Xiangling'].includes(c.name);
-                        }).concat(weapons.filter((c) => {
-                            return c.rarity == 4;
-                        }));
-                    banners.venti.regular.threeStars = weapons.filter((c) => {
-                            return c.rarity == 3;
-                        });
-                    console.log(banners)
-                })
-                .catch(error => {
-                    console.error('Error fetching character data:', error);
-                });
-        })
-        .catch(error => {
-            console.error('Error fetching character data:', error);
+    banners.standard.fiveStars = characters.filter((c) => {
+            return c.rarity == 5 && !['Venti', 'Klee', 'Xiao', 'Tartaglia', 'Zhongli'].includes(c.name);
+        }).concat(weapons.filter((c) => {
+            return c.rarity == 5;
+        }));
+    banners.standard.fourStars = characters.filter((c) => {
+            return c.rarity == 4;
+        }).concat(weapons.filter((c) => {
+            return c.rarity == 4;
+        }));
+    banners.standard.threeStars = weapons.filter((c) => {
+            return c.rarity == 3;
+        });
+    banners.venti.featured.fiveStar = characters.filter((c) => {
+            return c.name == 'Venti';
+        });
+    banners.venti.featured.fourStars = characters.filter((c) => {
+            return c.rarity == 4 && ['Fischl', 'Sucrose', 'Xiangling'].includes(c.name);
+        });
+    banners.venti.regular.fiveStars = characters.filter((c) => {
+            return c.rarity == 5 && !['Venti', 'Klee', 'Xiao', 'Tartaglia', 'Zhongli'].includes(c.name);
+        });
+    banners.venti.regular.fourStars = characters.filter((c) => {
+            return c.rarity == 4 && !['Kaeya', 'Lisa', 'Amber', 'Fischl', 'Sucrose', 'Xiangling'].includes(c.name);
+        }).concat(weapons.filter((c) => {
+            return c.rarity == 4;
+        }));
+    banners.venti.regular.threeStars = weapons.filter((c) => {
+            return c.rarity == 3;
         });
 });