Skip to content

Commit e94e7ea

Browse files
committed
fix: adjust history slice lengths for five-star and four-star rarity checks
- this was preventing 4star guarantees and causing pity wishes to be 1 off the correct number
1 parent 41db8d8 commit e94e7ea

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

script.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,10 +1288,10 @@ document.getElementById('wish-button').addEventListener('click', function() {
12881288
const fourStarChance = 0.051;
12891289
for (let i = 0; i < 10; i++) {
12901290
const roll = Math.random();
1291-
const recentlyFoundFive = currentBanner.history.slice(-90).some(item => item.rarity == 5);
1292-
const recentlyFoundFour = currentBanner.history.slice(-10).some(item => item.rarity == 4);
1293-
const isFive = (roll < fiveStarChance) || (currentBanner.history.length > 89 && !recentlyFoundFive);
1294-
const isFour = (roll < fourStarChance) || (currentBanner.history.length > 9 && !recentlyFoundFour);
1291+
const recentlyFoundFive = currentBanner.history.slice(-89).some(item => item.rarity == 5);
1292+
const recentlyFoundFour = currentBanner.history.slice(-9).some(item => item.rarity == 4);
1293+
const isFive = (roll < fiveStarChance) || (currentBanner.history.length >= 89 && !recentlyFoundFive);
1294+
const isFour = (roll < fourStarChance) || (currentBanner.history.length >= 9 && !recentlyFoundFour);
12951295
let item;
12961296
if (isFive) {
12971297
item = currentBanner.fiveStars[Math.floor(Math.random() * (currentBanner.fiveStars.length - 1))];
@@ -1330,10 +1330,10 @@ document.getElementById('wish-button').addEventListener('click', function() {
13301330
const fourStarChance = 0.051;
13311331
for (let i = 0; i < 10; i++) {
13321332
const roll = Math.random();
1333-
const recentlyFoundFive = currentBanner.history.slice(-90).some(item => item.rarity == 5);
1334-
const recentlyFoundFour = currentBanner.history.slice(-10).some(item => item.rarity == 4);
1335-
const isFive = (roll < fiveStarChance) || (currentBanner.history.length > 89 && !recentlyFoundFive);
1336-
const isFour = (roll < fourStarChance) || (currentBanner.history.length > 9 && !recentlyFoundFour);
1333+
const recentlyFoundFive = currentBanner.history.slice(-89).some(item => item.rarity == 5);
1334+
const recentlyFoundFour = currentBanner.history.slice(-9).some(item => item.rarity == 4);
1335+
const isFive = (roll < fiveStarChance) || (currentBanner.history.length >= 89 && !recentlyFoundFive);
1336+
const isFour = (roll < fourStarChance) || (currentBanner.history.length >= 9 && !recentlyFoundFour);
13371337
let item;
13381338
if (isFive) {
13391339
const isFeatured = Math.random() < 0.5;

0 commit comments

Comments
 (0)