Skip to content

Commit 1808796

Browse files
committed
tests improved
1 parent f24f714 commit 1808796

File tree

1 file changed

+3
-20
lines changed

1 file changed

+3
-20
lines changed

tests/Annotation/RouteTest.php

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ public function testConstructorParamsContainInvalidSummary($invalidSummary) : vo
330330
/**
331331
* @param mixed $invalidDescription
332332
* @return void
333-
* @dataProvider invalidDataProviderIfArrayOrStringExpected
333+
* @dataProvider invalidDataProviderIfStringExpected
334334
*/
335335
public function testConstructorParamsContainInvalidDescription($invalidDescription) : void
336336
{
@@ -389,7 +389,7 @@ public function testConstructorParamsContainInvalidPriority($invalidPriority) :
389389
public function testConstructorMethodsParamContainsInvalidValue($invalidMethod) : void
390390
{
391391
$this->expectException(InvalidDescriptorArgumentException::class);
392-
$this->expectExceptionMessage('@Route.methods must contain strings.');
392+
$this->expectExceptionMessage('@Route.methods must contain non-empty strings.');
393393

394394
new Route([
395395
'name' => 'foo',
@@ -456,7 +456,7 @@ public function testConstructorMiddlewaresParamContainsNonMiddlewareClass() : vo
456456
public function testConstructorTagsParamContainsInvalidValue($invalidTag) : void
457457
{
458458
$this->expectException(InvalidDescriptorArgumentException::class);
459-
$this->expectExceptionMessage('@Route.tags must contain strings.');
459+
$this->expectExceptionMessage('@Route.tags must contain non-empty strings.');
460460

461461
new Route([
462462
'name' => 'foo',
@@ -519,21 +519,4 @@ public function invalidDataProviderIfStringExpected() : array
519519
[\STDOUT],
520520
];
521521
}
522-
523-
/**
524-
* @return array
525-
*/
526-
public function invalidDataProviderIfArrayOrStringExpected() : array
527-
{
528-
return [
529-
[true],
530-
[false],
531-
[0],
532-
[0.0],
533-
[new \stdClass],
534-
[function () {
535-
}],
536-
[\STDOUT],
537-
];
538-
}
539522
}

0 commit comments

Comments
 (0)