LSP diagnostics ranges can't be empty (fixes #92)

Author: suoto

hdl_checker/lsp.py

@@ -114,7 +114,9 @@ def checkerDiagToLspDict(diag: CheckerDiagnostic) -> Diagnostic:
             start=Position(
                 line=diag.line_number or 0, character=diag.column_number or 0
             ),
-            end=Position(line=diag.line_number or 0, character=diag.column_number or 0),
+            end=Position(
+                line=diag.line_number or 0, character=(diag.column_number or 0) + 1
+            ),
         ),
         message=diag.text,
         severity=_translateSeverity(diag.severity),
@@ -323,7 +325,7 @@ def references(self, params: ReferenceParams) -> Optional[List[Location]]:
                     Location(
                         uri=from_fs_path(str(element.owner)),
                         range=Range(
-                            start=Position(line, column), end=Position(line, column)
+                            start=Position(line, column), end=Position(line, column + 1)
                         ),
                     )
                 ]
@@ -334,7 +336,7 @@ def references(self, params: ReferenceParams) -> Optional[List[Location]]:
                     Location(
                         uri=from_fs_path(str(reference.owner)),
                         range=Range(
-                            start=Position(line, column), end=Position(line, column)
+                            start=Position(line, column), end=Position(line, column + 1)
                         ),
                     )
                 ]
@@ -465,7 +467,7 @@ def hover(self, params: HoverParams) -> Optional[Hover]:
                     line=params.position.line, character=params.position.character
                 ),
                 end=Position(
-                    line=params.position.line, character=params.position.character
+                    line=params.position.line, character=params.position.character + 1
                 ),
             ),
         )
@@ -505,7 +507,7 @@ def definitions(
         # Included paths are dependencies but they're referred to by path, so
         # we return a definition to point to the beginning of the file
         if isinstance(dependency, IncludedPath):
-            return [Location(target_uri, Range(Position(0, 0), Position(0, 0)))]
+            return [Location(target_uri, Range(Position(0, 0), Position(0, 1)))]
 
         locations: List[Location] = []
 

hdl_checker/tests/test_lsp.py

@@ -891,8 +891,8 @@ def test_ReferencesOfAValidElement(self, get_references) -> Any:
         self.assertCountEqual(
             references,
             {
-                (uris.from_fs_path("some_path"), 1, 2, 1, 2),
-                (uris.from_fs_path("some_path"), 3, 4, 3, 4),
+                (uris.from_fs_path("some_path"), 1, 2, 1, 3),
+                (uris.from_fs_path("some_path"), 3, 4, 3, 5),
             },
         )
 
@@ -920,9 +920,9 @@ def test_ReferencesOfAValidElement(self, get_references) -> Any:
         self.assertCountEqual(
             references,
             {
-                (uris.from_fs_path(path_to_foo), 7, 7, 7, 7),
-                (uris.from_fs_path("some_path"), 1, 2, 1, 2),
-                (uris.from_fs_path("some_path"), 3, 4, 3, 4),
+                (uris.from_fs_path(path_to_foo), 7, 7, 7, 8),
+                (uris.from_fs_path("some_path"), 1, 2, 1, 3),
+                (uris.from_fs_path("some_path"), 3, 4, 3, 5),
             },
         )
 

hdl_checker/tests/test_lsp_utils.py

@@ -80,7 +80,7 @@ def test_convertingDiagnosticType(self, diag_type, severity):
         self.assertEqual(
             diag.range,
             Range(
-                start=Position(line=0, character=0), end=Position(line=0, character=0),
+                start=Position(line=0, character=0), end=Position(line=0, character=1),
             ),
         )