fix: Only warn if multiple clients share a storage-key

This allows use of multiple clients with different storage-keys, without the `Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key.` warning appearing.

The storageKey has also been added to the prefix of the debug messages to help with tracing.
The same prefix has been added to the warning for consistency
 If debug messages are enabled, the warning will also output a trace in addition to the warning to assist the user in tracking down where their multiple instances are being created from.

Author: sh41

test/GoTrueClient.browser.test.ts

@@ -110,12 +110,12 @@ describe('GoTrueClient in browser environment', () => {
     try {
       consoleWarnSpy = jest.spyOn(console, 'warn')
       consoleTraceSpy = jest.spyOn(console, 'trace')
-      getClientWithSpecificStorageKey('test-storage-key')
-      getClientWithSpecificStorageKey('test-storage-key')
+      getClientWithSpecificStorageKey('same-storage-key')
+      getClientWithSpecificStorageKey('same-storage-key')
       expect(consoleWarnSpy).toHaveBeenCalledTimes(1)
       expect(consoleWarnSpy).toHaveBeenCalledWith(
         expect.stringMatching(
-          /GoTrueClient@test-storage-key:1 .* Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key./
+          /GoTrueClient@same-storage-key:1 .* Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key./
         )
       )
       expect(consoleTraceSpy).not.toHaveBeenCalled()
@@ -131,17 +131,17 @@ describe('GoTrueClient in browser environment', () => {
     try {
       consoleWarnSpy = jest.spyOn(console, 'warn')
       consoleTraceSpy = jest.spyOn(console, 'trace')
-      getClientWithSpecificStorageKey('test-storage-key')
-      getClientWithSpecificStorageKey('test-storage-key', { debug: true })
+      getClientWithSpecificStorageKey('identical-storage-key')
+      getClientWithSpecificStorageKey('identical-storage-key', { debug: true })
       expect(consoleWarnSpy).toHaveBeenCalledTimes(1)
       expect(consoleWarnSpy).toHaveBeenCalledWith(
         expect.stringMatching(
-          /GoTrueClient@test-storage-key:1 .* Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key./
+          /GoTrueClient@identical-storage-key:1 .* Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key./
         )
       )
       expect(consoleTraceSpy).toHaveBeenCalledWith(
         expect.stringMatching(
-          /GoTrueClient@test-storage-key:1 .* Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key./
+          /GoTrueClient@identical-storage-key:1 .* Multiple GoTrueClient instances detected in the same browser context. It is not an error, but this should be avoided as it may produce undefined behavior when used concurrently under the same storage key./
         )
       )
     } finally {
@@ -156,8 +156,8 @@ describe('GoTrueClient in browser environment', () => {
     try {
       consoleWarnSpy = jest.spyOn(console, 'warn')
       consoleTraceSpy = jest.spyOn(console, 'trace')
-      getClientWithSpecificStorageKey('test-storage-key1')
-      getClientWithSpecificStorageKey('test-storage-key2')
+      getClientWithSpecificStorageKey('first-storage-key')
+      getClientWithSpecificStorageKey('second-storage-key')
       expect(consoleWarnSpy).not.toHaveBeenCalled()
       expect(consoleTraceSpy).not.toHaveBeenCalled()
     } finally {
@@ -166,7 +166,7 @@ describe('GoTrueClient in browser environment', () => {
     }
   })
 
-  it('should not warn only when a second client with a duplicate key is created', () => {
+  it('should warn only when a second client with a duplicate key is created', () => {
     let consoleWarnSpy
     let consoleTraceSpy
     try {