fix: mfa challenge channel field not required (#603)

silentworks · web-flow · commit 38a8696058c4 · 2024-09-30T11:52:29.000Z
diff --git a/supabase_auth/_async/gotrue_client.py b/supabase_auth/_async/gotrue_client.py
@@ -822,7 +822,7 @@ async def _challenge(self, params: MFAChallengeParams) -> AuthMFAChallengeRespon
         return await self._request(
             "POST",
             f"factors/{params.get('factor_id')}/challenge",
-            body={"channel": params["channel"]},
+            body={"channel": params.get("channel")},
             jwt=session.access_token,
             xform=partial(model_validate, AuthMFAChallengeResponse),
         )
diff --git a/supabase_auth/_sync/gotrue_client.py b/supabase_auth/_sync/gotrue_client.py
@@ -814,7 +814,7 @@ def _challenge(self, params: MFAChallengeParams) -> AuthMFAChallengeResponse:
         return self._request(
             "POST",
             f"factors/{params.get('factor_id')}/challenge",
-            body={"channel": params["channel"]},
+            body={"channel": params.get("channel")},
             jwt=session.access_token,
             xform=partial(model_validate, AuthMFAChallengeResponse),
         )

Original file line number	Diff line number	Diff line change
`@@ -822,7 +822,7 @@ async def _challenge(self, params: MFAChallengeParams) -> AuthMFAChallengeRespon`
`822`	`822`	`return await self._request(`
`823`	`823`	`"POST",`
`824`	`824`	`f"factors/{params.get('factor_id')}/challenge",`
`825`		`- body={"channel": params["channel"]},`
	`825`	`+ body={"channel": params.get("channel")},`
`826`	`826`	`jwt=session.access_token,`
`827`	`827`	`xform=partial(model_validate, AuthMFAChallengeResponse),`
`828`	`828`	`)`
Original file line number	Diff line number	Diff line change
`@@ -814,7 +814,7 @@ def _challenge(self, params: MFAChallengeParams) -> AuthMFAChallengeResponse:`
`814`	`814`	`return self._request(`
`815`	`815`	`"POST",`
`816`	`816`	`f"factors/{params.get('factor_id')}/challenge",`
`817`		`- body={"channel": params["channel"]},`
	`817`	`+ body={"channel": params.get("channel")},`
`818`	`818`	`jwt=session.access_token,`
`819`	`819`	`xform=partial(model_validate, AuthMFAChallengeResponse),`
`820`	`820`	`)`