fix(passkeys): return 204 when deleting a passkey

Author: fadymak

internal/api/passkey_manage.go

@@ -144,7 +144,8 @@ func (a *API) PasskeyDelete(w http.ResponseWriter, r *http.Request) error {
 		return apierrors.NewInternalServerError("Database error deleting passkey").WithInternalError(err)
 	}
 
-	return sendJSON(w, http.StatusOK, toPasskeyListItem(cred))
+	w.WriteHeader(http.StatusNoContent)
+	return nil
 }
 
 func toPasskeyListItem(cred *models.WebAuthnCredential) PasskeyListItem {

internal/api/passkey_manage_test.go

@@ -201,11 +201,8 @@ func (ts *PasskeyTestSuite) TestPasskeyDelete() {
 	token := ts.generateToken(ts.TestUser, &ts.TestSession.ID)
 	w := ts.makeRequest(http.MethodDelete, fmt.Sprintf("http://localhost/passkeys/%s", cred.ID), nil, withBearerToken(token))
 
-	ts.Equal(http.StatusOK, w.Code)
-
-	var item PasskeyListItem
-	require.NoError(ts.T(), json.NewDecoder(w.Body).Decode(&item))
-	ts.Equal(cred.ID.String(), item.ID)
+	ts.Equal(http.StatusNoContent, w.Code)
+	ts.Empty(w.Body.Bytes())
 
 	// Verify deleted from database
 	_, err := models.FindWebAuthnCredentialByID(ts.API.db, cred.ID)