Skip to content

Commit 37438c4

Browse files
committed
fix: assume platform defaults when local sms keys are unset
1 parent d412bc0 commit 37438c4

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

pkg/config/auth.go

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -542,25 +542,35 @@ func (s sms) toAuthConfigBody(body *v1API.UpdateAuthConfigBody) {
542542
switch {
543543
case s.Twilio.Enabled:
544544
body.SmsProvider = cast.Ptr("twilio")
545-
body.SmsTwilioAuthToken = &s.Twilio.AuthToken
545+
if len(s.Twilio.AuthToken) > 0 {
546+
body.SmsTwilioAuthToken = &s.Twilio.AuthToken
547+
}
546548
body.SmsTwilioAccountSid = &s.Twilio.AccountSid
547549
body.SmsTwilioMessageServiceSid = &s.Twilio.MessageServiceSid
548550
case s.TwilioVerify.Enabled:
549551
body.SmsProvider = cast.Ptr("twilio_verify")
550-
body.SmsTwilioVerifyAuthToken = &s.TwilioVerify.AuthToken
552+
if len(s.TwilioVerify.AuthToken) > 0 {
553+
body.SmsTwilioVerifyAuthToken = &s.TwilioVerify.AuthToken
554+
}
551555
body.SmsTwilioVerifyAccountSid = &s.TwilioVerify.AccountSid
552556
body.SmsTwilioVerifyMessageServiceSid = &s.TwilioVerify.MessageServiceSid
553557
case s.Messagebird.Enabled:
554558
body.SmsProvider = cast.Ptr("messagebird")
555-
body.SmsMessagebirdAccessKey = &s.Messagebird.AccessKey
559+
if len(s.Messagebird.AccessKey) > 0 {
560+
body.SmsMessagebirdAccessKey = &s.Messagebird.AccessKey
561+
}
556562
body.SmsMessagebirdOriginator = &s.Messagebird.Originator
557563
case s.Textlocal.Enabled:
558564
body.SmsProvider = cast.Ptr("textlocal")
559-
body.SmsTextlocalApiKey = &s.Textlocal.ApiKey
565+
if len(s.Textlocal.ApiKey) > 0 {
566+
body.SmsTextlocalApiKey = &s.Textlocal.ApiKey
567+
}
560568
body.SmsTextlocalSender = &s.Textlocal.Sender
561569
case s.Vonage.Enabled:
562570
body.SmsProvider = cast.Ptr("vonage")
563-
body.SmsVonageApiSecret = &s.Vonage.ApiSecret
571+
if len(s.Vonage.ApiSecret) > 0 {
572+
body.SmsVonageApiSecret = &s.Vonage.ApiSecret
573+
}
564574
body.SmsVonageApiKey = &s.Vonage.ApiKey
565575
body.SmsVonageFrom = &s.Vonage.From
566576
}

0 commit comments

Comments
 (0)