Skip to content

Commit 4c34438

Browse files
authored
fix: use wildcard to filter reserved roles (#4780)
* fix: ignore login role from dump * fix: use wildcard to filter reserved roles * fix: check if config is updated
1 parent 80b3444 commit 4c34438

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

internal/migration/format/format.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ func appendConfig(fsys afero.Fs) error {
691691
if err != nil && !errors.Is(err, os.ErrNotExist) {
692692
return errors.Errorf("failed to read config: %w", err)
693693
}
694-
if newConfig := pattern.ReplaceAllLiteral(data, []byte(schemaPaths)); !bytes.Equal(data, newConfig) {
694+
if newConfig := pattern.ReplaceAllLiteral(data, []byte(schemaPaths)); bytes.Contains(newConfig, []byte(schemaPaths)) {
695695
return utils.WriteFile(utils.ConfigPath, newConfig, fsys)
696696
}
697697
// Fallback to append

pkg/migration/dump.go

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87,19 +87,12 @@ var (
8787
"anon",
8888
"authenticated",
8989
"authenticator",
90+
"cli_login_.*",
9091
"dashboard_user",
9192
"pgbouncer",
9293
"postgres",
9394
"service_role",
94-
"supabase_admin",
95-
"supabase_auth_admin",
96-
"supabase_etl_admin",
97-
"supabase_functions_admin",
98-
"supabase_read_only_user",
99-
"supabase_realtime_admin",
100-
"supabase_replication_admin",
101-
"supabase_storage_admin",
102-
"supabase_superuser",
95+
"supabase_.*",
10396
// Managed by extensions
10497
"pgsodium_keyholder",
10598
"pgsodium_keyiduser",

0 commit comments

Comments
 (0)