[ADD] migration up and tests

Author: JohnBra

internal/migration/up/up.go

@@ -23,6 +23,7 @@ func Run(ctx context.Context, includeAll bool, config pgconn.Config, fsys afero.
 	if err != nil {
 		return err
 	}
+
 	return migration.ApplyMigrations(ctx, pending, conn, afero.NewIOFS(fsys))
 }
 
@@ -45,6 +46,11 @@ func GetPendingMigrations(ctx context.Context, includeAll bool, conn *pgx.Conn,
 		}
 		utils.CmdSuggestion = suggestIgnoreFlag(diff)
 	}
+	repeatableMigrations, err := migration.ListRepeatableMigrations(utils.MigrationsDir, afero.NewIOFS(fsys))
+	if err != nil {
+		return nil, err
+	}
+	diff = append(diff, repeatableMigrations...)
 	return diff, err
 }
 

pkg/migration/list.go

@@ -8,6 +8,7 @@ import (
 	"path/filepath"
 	"regexp"
 	"strconv"
+	"strings"
 
 	"github.com/go-errors/errors"
 	"github.com/jackc/pgconn"
@@ -45,6 +46,10 @@ func ListLocalMigrations(migrationsDir string, fsys fs.FS, filter ...func(string
 			fmt.Fprintf(os.Stderr, "Skipping migration %s... (replace \"init\" with a different file name to apply this migration)\n", filename)
 			continue
 		}
+		if strings.HasPrefix(filename, "r_") {
+			// silently skip repeatable migrations
+			continue
+		}
 		matches := migrateFilePattern.FindStringSubmatch(filename)
 		if len(matches) == 0 {
 			fmt.Fprintf(os.Stderr, "Skipping migration %s... (file name must match pattern \"<timestamp>_name.sql\")\n", filename)
@@ -60,6 +65,24 @@ func ListLocalMigrations(migrationsDir string, fsys fs.FS, filter ...func(string
 	return clean, nil
 }
 
+func ListRepeatableMigrations(migrationsDir string, fsys fs.FS) ([]string, error) {
+	localMigrations, err := fs.ReadDir(fsys, migrationsDir)
+	if err != nil && !errors.Is(err, os.ErrNotExist) {
+		return nil, errors.Errorf("failed to read directory: %w", err)
+	}
+	var repeatable []string
+
+	for _, migration := range localMigrations {
+		filename := migration.Name()
+		if strings.HasPrefix(filename, "r_") && strings.HasSuffix(filename, ".sql") {
+			path := filepath.Join(migrationsDir, filename)
+			repeatable = append(repeatable, path)
+		}
+	}
+
+	return repeatable, nil
+}
+
 var initSchemaPattern = regexp.MustCompile(`([0-9]{14})_init\.sql`)
 
 func shouldSkip(name string) bool {

pkg/migration/list_test.go

@@ -90,3 +90,44 @@ func TestLocalMigrations(t *testing.T) {
 		assert.ErrorContains(t, err, "failed to read directory:")
 	})
 }
+
+func TestRepeatableMigrations(t *testing.T) {
+	t.Run("loads repeatable migrations", func(t *testing.T) {
+		// Setup in-memory fs
+		files := []string{
+			"r_test_view.sql",
+			"r_test_function.sql",
+		}
+		fsys := fs.MapFS{}
+		for _, name := range files {
+			fsys[name] = &fs.MapFile{}
+		}
+		// Run test
+		versions, err := ListRepeatableMigrations(".", fsys)
+		// Check error
+		assert.NoError(t, err)
+		assert.ElementsMatch(t, files, versions)
+	})
+
+	t.Run("ignores files without 'r_' prefix", func(t *testing.T) {
+		// Setup in-memory fs
+		fsys := fs.MapFS{
+			"20211208000000_init.sql": &fs.MapFile{},
+			"r_invalid.ts":            &fs.MapFile{},
+		}
+		// Run test
+		versions, err := ListRepeatableMigrations(".", fsys)
+		// Check error
+		assert.NoError(t, err)
+		assert.Empty(t, versions)
+	})
+
+	t.Run("throws error on open failure", func(t *testing.T) {
+		// Setup in-memory fs
+		fsys := fs.MapFS{"migrations": &fs.MapFile{}}
+		// Run test
+		_, err := ListRepeatableMigrations("migrations", fsys)
+		// Check error
+		assert.ErrorContains(t, err, "failed to read directory:")
+	})
+}