Skip to content

Commit cae4a03

Browse files
fix: early fail on non-exposed docker daemon (#3592)
* fix: early fail on non-exposed docker daemon * Removed redundant check and removed vector from start check on windows * Update internal/start/start.go --------- Co-authored-by: Han Qiao <[email protected]>
1 parent ce6afd0 commit cae4a03

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

internal/start/start.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ EOF
280280
}
281281
env = append(env, "DOCKER_HOST="+dindHost.String())
282282
case "npipe":
283-
fmt.Fprintln(os.Stderr, utils.Yellow("WARNING:"), "analytics requires docker daemon exposed on tcp://localhost:2375")
283+
const dockerDaemonNeededErr = "Analytics on Windows requires Docker daemon exposed on tcp://localhost:2375.\nSee https://supabase.com/docs/guides/local-development/cli/getting-started?queryGroups=platform&platform=windows#running-supabase-locally for more details."
284+
fmt.Fprintln(os.Stderr, utils.Yellow("WARNING:"), dockerDaemonNeededErr)
284285
env = append(env, "DOCKER_HOST="+dindHost.String())
285286
case "unix":
286287
if dindHost, err = client.ParseHostURL(client.DefaultDockerHost); err != nil {
@@ -328,7 +329,9 @@ EOF
328329
); err != nil {
329330
return err
330331
}
331-
started = append(started, utils.VectorId)
332+
if parsed.Scheme != "npipe" {
333+
started = append(started, utils.VectorId)
334+
}
332335
}
333336

334337
// Start Kong.

0 commit comments

Comments
 (0)