chore: Refactor printlns to logs

Author: andreespirela

Cargo.lock

@@ -9,7 +9,7 @@ use tokio::sync::oneshot::Receiver;
 
 impl WorkerHandler for Worker {
     fn handle_error(&self, error: Error) -> Result<WorkerEvents, Error> {
-        println!("{}", error);
+        log::error!("{}", error);
         Ok(WorkerEvents::BootFailure(BootFailureEvent {
             msg: error.to_string(),
         }))

crates/base/src/rt_worker/implementation/default_handler.rs

@@ -71,5 +71,8 @@ async fn test_user_imports_npm() {
 
     let body_bytes = hyper::body::to_bytes(res.into_body()).await.unwrap();
 
-    assert_eq!(body_bytes, r#"{"is_even":true}"#);
+    assert_eq!(
+        body_bytes,
+        r#"{"is_even":true,"hello":"","numbers":{"Uno":1,"Dos":2}}"#
+    );
 }

crates/base/tests/user_worker_tests.rs

@@ -77,7 +77,7 @@ impl CPUTimer {
 
     #[cfg(not(target_os = "linux"))]
     pub fn start(_: u64, _: u64, _: CPUAlarmVal) -> Result<Self, Error> {
-        println!("CPU timer: not enabled (need Linux)");
+        log::error!("CPU timer: not enabled (need Linux)");
         Ok(Self {})
     }
 }

crates/cpu_timer/src/lib.rs

@@ -70,3 +70,4 @@ winapi = "=0.3.9"
 # https://github.com/dalek-cryptography/x25519-dalek/pull/89
 x25519-dalek = "2.0.0-pre.1"
 x509-parser = "0.15.0"
+log.workspace = true

crates/node/Cargo.toml

@@ -248,13 +248,13 @@ fn is_managed_key(scope: &mut v8::HandleScope, key: v8::Local<v8::Name>) -> bool
 
 fn current_mode(scope: &mut v8::HandleScope) -> Mode {
     let Some(v8_string) = v8::StackTrace::current_script_name_or_source_url(scope) else {
-        println!("current_script_name_or_source_url, Using Deno");
+        log::debug!("current_script_name_or_source_url, Using SB");
         return Mode::Deno;
     };
     let op_state = deno_core::JsRuntime::op_state_from(scope);
     let op_state = op_state.borrow();
     let Some(node_resolver) = op_state.try_borrow::<Rc<NodeResolver>>() else {
-        println!("Node resolver not available, using Deno");
+        log::debug!("Node resolver not available, using SB");
         return Mode::Deno;
     };
     let mut buffer = [MaybeUninit::uninit(); 2048];

crates/node/global.rs

@@ -493,7 +493,6 @@ pub async fn op_http2_client_get_response_body_chunk(
                 return Ok((Some(data.to_vec()), false));
             }
             DataOrTrailers::Trailers(trailers) => {
-                println!("{trailers:?}");
                 if let Some(trailers_tx) = RcRef::map(&resource, |r| &r.trailers_tx)
                     .borrow_mut()
                     .await

crates/node/ops/http2.rs

@@ -30,4 +30,5 @@ percent-encoding = "=2.3.0"
 hex = "0.4"
 base64.workspace = true
 bincode = "=1.3.3"
-thiserror.workspace = true
+thiserror.workspace = true
+log.workspace = true

crates/npm/Cargo.toml

@@ -10,6 +10,7 @@ use deno_core::futures::StreamExt;
 use deno_npm::registry::NpmRegistryApi;
 use deno_npm::registry::NpmRegistryPackageInfoLoadError;
 use deno_semver::package::PackageReq;
+use log::debug;
 use sb_core::util::sync::AtomicFlag;
 
 use super::CliNpmRegistryApi;
@@ -91,7 +92,7 @@ impl PackageJsonDepsInstaller {
                 .resolve_pkg_id_from_pkg_req(req)
                 .is_ok()
         }) {
-            println!("All package.json deps resolvable. Skipping top level install.");
+            debug!("All package.json deps resolvable. Skipping top level install.");
             return Ok(()); // everything is already resolvable
         }
 
@@ -104,7 +105,7 @@ impl PackageJsonDepsInstaller {
                 .resolve_package_req_as_pending_with_info(req, &info);
             if let Err(err) = result {
                 if inner.npm_registry_api.mark_force_reload() {
-                    println!("Failed to resolve package. Retrying. Error: {err:#}");
+                    debug!("Failed to resolve package. Retrying. Error: {err:#}");
                     // re-initialize
                     reqs_with_info_futures = inner.reqs_with_info_futures(&package_reqs);
                 } else {

crates/npm/installer.rs

@@ -21,6 +21,7 @@ use deno_core::url::Url;
 use deno_npm::registry::NpmPackageInfo;
 use deno_npm::registry::NpmRegistryApi;
 use deno_npm::registry::NpmRegistryPackageInfoLoadError;
+use log::debug;
 use once_cell::sync::Lazy;
 use sb_core::cache::CacheSetting;
 use sb_core::cache::CACHE_PERM;
@@ -288,7 +289,7 @@ impl CliNpmRegistryApiInner {
         &self,
         name: &str,
     ) -> Result<Option<NpmPackageInfo>, AnyError> {
-        println!("Downloading load_package_info_from_registry_inner");
+        debug!("Downloading load_package_info_from_registry_inner");
         if *self.cache.cache_setting() == CacheSetting::Only {
             return Err(custom_error(
                 "NotCached",