feat: Merge pull request #244 from nyannyacha/perf-use-green-thread

feat: use the tokio task instead of the native thread to poll each isolate

Author: laktek

Cargo.lock

@@ -42,6 +42,7 @@ deno_webidl = { version = "0.121.0" }
 deno_web = { version = "0.152.0" }
 deno_websocket = { version = "0.126.0" }
 deno_webstorage = { version = "0.116.0" }
+enum-as-inner = "0.6.0"
 serde = { version = "1.0.149", features = ["derive"] }
 hyper = "0.14.26"
 tokio = { version = "1.28.1", features = ["full"] }
@@ -66,6 +67,7 @@ import_map = { version = "0.15.0" }
 base64 = { version = "=0.13.1" }
 futures = { version = "0.3.28" }
 futures-util = { version = "0.3.28" }
+ctor = { version = "0.2.6" }
 
 [profile.release]
 lto = true

Cargo.toml

@@ -38,7 +38,7 @@ log = { workspace = true }
 reqwest.workspace = true
 serde = { version = "1.0.149", features = ["derive"] }
 tokio = { workspace = true }
-tokio-util = { workspace = true }
+tokio-util = { workspace = true, features = ["rt"] }
 futures-util = { workspace = true }
 url = { version = "2.3.1" }
 event_worker ={ version = "0.1.0", path = "../event_worker" }
@@ -55,11 +55,15 @@ sb_node = { version = "0.1.0", path = "../node" }
 eszip.workspace = true
 notify = { version = "6.1.1", default-features = false, features = ["macos_kqueue"] }
 flume = { version = "0.11.0" }
-strum = { version = "0.25.0", features = ["derive"] }
+enum-as-inner.workspace = true
 urlencoding.workspace = true
+scopeguard = { version = "1.2.0" }
+pin-project = { version = "1.1.3" }
+ctor = { workspace = true }
 
 [dev-dependencies]
 flaky_test = { version = "0.1.0", path = "../flaky_test" }
+serial_test = { version = "3.0.0" }
 
 [build-dependencies]
 sb_core = { version = "0.1.0", path = "../sb_core" }

crates/base/Cargo.toml

@@ -1,10 +1,8 @@
 use crate::{
-    rt_worker::worker_pool::WorkerPoolPolicy,
-    server::{Server, ServerCodes, WorkerEntrypoints},
+    rt_worker::{worker_ctx::TerminationToken, worker_pool::WorkerPoolPolicy},
+    server::{Server, ServerHealth, WorkerEntrypoints},
 };
 use anyhow::Error;
-use deno_core::JsRuntime;
-use log::error;
 use tokio::sync::mpsc::Sender;
 
 #[allow(clippy::too_many_arguments)]
@@ -16,17 +14,10 @@ pub async fn start_server(
     user_worker_policy: Option<WorkerPoolPolicy>,
     import_map_path: Option<String>,
     no_module_cache: bool,
-    no_signal_handler: bool,
-    callback_tx: Option<Sender<ServerCodes>>,
+    callback_tx: Option<Sender<ServerHealth>>,
     entrypoints: WorkerEntrypoints,
+    termination_token: Option<TerminationToken>,
 ) -> Result<(), Error> {
-    set_v8_flags();
-
-    // NOTE(denoland/deno/20495): Due to the new PKU (Memory Protection Keys)
-    // feature introduced in V8 11.6, We need to initialize the V8 platform on
-    // the main thread that spawns V8 isolates.
-    JsRuntime::init_platform(None);
-
     let mut server = Server::new(
         ip,
         port,
@@ -35,27 +26,11 @@ pub async fn start_server(
         user_worker_policy,
         import_map_path,
         no_module_cache,
-        no_signal_handler,
         callback_tx,
         entrypoints,
+        termination_token,
     )
     .await?;
-    server.listen().await
-}
-
-fn set_v8_flags() {
-    let v8_flags = std::env::var("V8_FLAGS").unwrap_or("".to_string());
-    let mut vec = vec![""];
 
-    if v8_flags.is_empty() {
-        return;
-    }
-
-    vec.append(&mut v8_flags.split(' ').collect());
-
-    let ignored = deno_core::v8_set_flags(vec.iter().map(|v| v.to_string()).collect());
-
-    if *ignored.as_slice() != [""] {
-        error!("v8 flags unrecognized {:?}", ignored);
-    }
+    server.listen().await
 }