Skip to content

Commit 5f99749

Browse files
committed
chore: comment
1 parent f111403 commit 5f99749

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

crates/base/src/rt_worker/worker_pool.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,17 @@ impl WorkerPool {
460460
let fence = Arc::new(Notify::const_new());
461461

462462
if let Err(ex) = req_start_tx.send(fence.clone()) {
463+
// NOTE(Nyannyacha): The only way to be trapped in
464+
// this branch is if the supervisor associated with
465+
// the isolate has been terminated for some reason,
466+
// such as a wall-clock timeout.
467+
//
468+
// It can be expected enough if many isolates are
469+
// created at once due to requests rapidly
470+
// increasing.
471+
//
472+
// To prevent this, we must give a wall-clock time
473+
// limit enough to each supervisor.
463474
error!("failed to notify the fence to the supervisor");
464475
return Err(ex)
465476
.with_context(|| "failed to notify the fence to the supervisor");

0 commit comments

Comments
 (0)