fix(base): pass import meta resolve callback when initialize JsRuntime (#421)

* fix(base): pass import meta resolve callback when initialize `JsRuntime`

* chore: add an integration test

Author: nyannyacha

crates/base/src/deno_runtime.rs

@@ -12,8 +12,8 @@ use deno_core::error::AnyError;
 use deno_core::url::Url;
 use deno_core::v8::{GCCallbackFlags, GCType, HeapStatistics, Isolate};
 use deno_core::{
-    located_script_name, serde_json, JsRuntime, ModuleCodeString, ModuleId, PollEventLoopOptions,
-    RuntimeOptions,
+    located_script_name, serde_json, JsRuntime, ModuleCodeString, ModuleId, ModuleLoader,
+    ModuleSpecifier, PollEventLoopOptions, ResolutionKind, RuntimeOptions,
 };
 use deno_http::DefaultHttpPropertyExtractor;
 use deno_tls::deno_native_certs::load_native_certs;
@@ -529,6 +529,7 @@ where
             compiled_wasm_module_store: None,
             startup_snapshot: snapshot::snapshot(),
             module_loader: Some(module_loader),
+            import_meta_resolve_callback: Some(Box::new(import_meta_resolve_callback)),
             ..Default::default()
         };
 
@@ -1001,6 +1002,14 @@ where
     }
 }
 
+pub fn import_meta_resolve_callback(
+    loader: &dyn ModuleLoader,
+    specifier: String,
+    referrer: String,
+) -> Result<ModuleSpecifier, AnyError> {
+    loader.resolve(&specifier, &referrer, ResolutionKind::DynamicImport)
+}
+
 fn get_current_cpu_time_ns() -> Result<i64, Error> {
     get_thread_time().context("can't get current thread time")
 }

crates/base/test_cases/issue-420/index.ts

@@ -0,0 +1,7 @@
+import * as _meow from "npm:@imagemagick/[email protected]";
+
+export default {
+    fetch() {
+        return new Response(import.meta.resolve("npm:@imagemagick/[email protected]"));
+    }
+}

crates/base/tests/integration_tests.rs

@@ -2325,6 +2325,29 @@ async fn test_declarative_style_fetch_handler() {
     );
 }
 
+#[tokio::test]
+#[serial]
+async fn test_issue_420() {
+    integration_test!(
+        "./test_cases/main",
+        NON_SECURE_PORT,
+        "issue-420",
+        None,
+        None,
+        None,
+        None,
+        (|resp| async {
+            let text = resp.unwrap().text().await.unwrap();
+
+            assert!(text.starts_with("file:///"));
+            assert!(text.ends_with(
+                "/node_modules/localhost/@imagemagick/magick-wasm/0.0.30/dist/index.js"
+            ));
+        }),
+        TerminationToken::new()
+    );
+}
+
 trait AsyncReadWrite: AsyncRead + AsyncWrite + Send + Unpin {}
 
 impl<T> AsyncReadWrite for T where T: AsyncRead + AsyncWrite + Send + Unpin {}