fix: shouldn't be initialized the v8 platform from DenoRuntime::new

At the time of invoking `DenoRuntime::new()`, it is a time that already detached
from the main thread.

The function initializes the V8 platform should be invoked only from the main
thread, so it's not right.

(cherry picked from commit 989867a)

Author: nyannyacha

Cargo.toml

@@ -67,6 +67,7 @@ import_map = { version = "0.15.0" }
 base64 = { version = "=0.13.1" }
 futures = { version = "0.3.28" }
 futures-util = { version = "0.3.28" }
+ctor = { version = "0.2.6" }
 
 [profile.release]
 lto = true

crates/base/Cargo.toml

@@ -38,7 +38,7 @@ log = { workspace = true }
 reqwest.workspace = true
 serde = { version = "1.0.149", features = ["derive"] }
 tokio = { workspace = true }
-tokio-util = { workspace = true, features = [ "rt" ] }
+tokio-util = { workspace = true, features = ["rt"] }
 futures-util = { workspace = true }
 url = { version = "2.3.1" }
 event_worker ={ version = "0.1.0", path = "../event_worker" }
@@ -59,6 +59,7 @@ enum-as-inner.workspace = true
 urlencoding.workspace = true
 scopeguard = { version = "1.2.0" }
 pin-project = { version = "1.1.3" }
+ctor = { workspace = true }
 
 [dev-dependencies]
 flaky_test = { version = "0.1.0", path = "../flaky_test" }

crates/base/src/deno_runtime.rs

@@ -3,6 +3,7 @@ use crate::utils::units::mib_to_bytes;
 
 use anyhow::{anyhow, bail, Context, Error};
 use cpu_timer::get_thread_time;
+use ctor::ctor;
 use deno_core::error::AnyError;
 use deno_core::url::Url;
 use deno_core::{located_script_name, serde_v8, JsRuntime, ModuleCode, ModuleId, RuntimeOptions};
@@ -13,7 +14,6 @@ use deno_tls::rustls_native_certs::load_native_certs;
 use deno_tls::RootCertStoreProvider;
 use futures_util::future::poll_fn;
 use log::{error, trace};
-use once_cell::sync::OnceCell;
 use sb_core::conn_sync::ConnSync;
 use serde::de::DeserializeOwned;
 use std::collections::HashMap;
@@ -46,6 +46,16 @@ use sb_node::deno_node;
 use sb_workers::context::{UserWorkerMsgs, WorkerContextInitOpts, WorkerRuntimeOpts};
 use sb_workers::sb_user_workers;
 
+#[ctor]
+fn init_v8_platform() {
+    set_v8_flags();
+
+    // NOTE(denoland/deno/20495): Due to the new PKU (Memory Protection Keys)
+    // feature introduced in V8 11.6, We need to initialize the V8 platform on
+    // the main thread that spawns V8 isolates.
+    JsRuntime::init_platform(None);
+}
+
 pub struct DenoRuntimeError(Error);
 
 impl PartialEq for DenoRuntimeError {
@@ -75,17 +85,6 @@ impl DenoRuntime {
     #[allow(clippy::unnecessary_literal_unwrap)]
     #[allow(clippy::arc_with_non_send_sync)]
     pub async fn new(opts: WorkerContextInitOpts) -> Result<Self, Error> {
-        static INITIALZE_V8_PLATFORM: OnceCell<()> = OnceCell::new();
-
-        INITIALZE_V8_PLATFORM.get_or_init(|| {
-            set_v8_flags();
-
-            // NOTE(denoland/deno/20495): Due to the new PKU (Memory Protection Keys)
-            // feature introduced in V8 11.6, We need to initialize the V8 platform on
-            // the main thread that spawns V8 isolates.
-            JsRuntime::init_platform(None);
-        });
-
         let WorkerContextInitOpts {
             service_path,
             no_module_cache,

crates/cpu_timer/Cargo.toml

@@ -11,7 +11,7 @@ libc = { workspace = true }
 nix = { version = "0.26.2", features = ["signal"] }
 tokio = { workspace = true }
 log = { workspace = true }
-ctor = { version = "0.2.6" }
+ctor = { workspace = true }
 futures = { workspace = true }
 signal-hook = { version = "0.3.17" }
 signal-hook-tokio = { version = "0.3.1", features = ["futures-v0_3"] }