fix(k8s): Inject actual environment when creating stateful set (#348)

Author: iambriccardo

etl-api/src/k8s/base.rs

@@ -10,16 +10,15 @@ use thiserror::Error;
 pub enum K8sError {
     /// A serialization or deserialization error while building or parsing
     /// Kubernetes resources.
-    #[error("An error occurred in serde: {0}")]
+    #[error("An error occurred in serde when dealing with K8s: {0}")]
     Serde(#[from] serde_json::error::Error),
     /// An error returned by the [`kube`] client when talking to the API
     /// server.
-    #[error("An error occurred with kube: {0}")]
+    #[error("An error occurred with kube when dealing with K8s: {0}")]
     Kube(#[from] kube::Error),
-    /// The environment-dependent replicator configuration could not be
-    /// determined.
-    #[error("An error occurred while configuring the replicator")]
-    ReplicatorConfiguration,
+    /// The environment was not found while configuring K8s.
+    #[error("Could not get environment when dealing with K8s")]
+    MissingEnvironment,
 }
 
 /// A simplified view of a pod phase.

etl-api/src/k8s/http.rs

@@ -74,9 +74,7 @@ struct DynamicReplicatorConfig {
 
 impl DynamicReplicatorConfig {
     /// Loads the runtime limits for the current environment.
-    fn load() -> Result<Self, K8sError> {
-        let environment = Environment::load().map_err(|_| K8sError::ReplicatorConfiguration)?;
-
+    fn load(environment: &Environment) -> Result<Self, K8sError> {
         let config = match environment {
             Environment::Prod => Self {
                 max_memory: REPLICATOR_MAX_MEMORY_PROD,
@@ -302,6 +300,9 @@ impl K8sClient for HttpK8sClient {
     ) -> Result<(), K8sError> {
         info!("patching stateful set");
 
+        let environment = Environment::load().map_err(|_| K8sError::MissingEnvironment)?;
+        let config = DynamicReplicatorConfig::load(&environment)?;
+
         let stateful_set_name = format!("{prefix}-{REPLICATOR_STATEFUL_SET_SUFFIX}");
         let replicator_app_name = format!("{prefix}-{REPLICATOR_APP_SUFFIX}");
         let replicator_container_name = format!("{prefix}-{REPLICATOR_CONTAINER_NAME_SUFFIX}");
@@ -310,8 +311,6 @@ impl K8sClient for HttpK8sClient {
         let bq_secret_name = format!("{prefix}-{BQ_SECRET_NAME_SUFFIX}");
         let replicator_config_map_name = format!("{prefix}-{REPLICATOR_CONFIG_MAP_NAME_SUFFIX}");
 
-        let config = DynamicReplicatorConfig::load()?;
-
         let mut stateful_set_json = json!({
           "apiVersion": "apps/v1",
           "kind": "StatefulSet",
@@ -419,7 +418,7 @@ impl K8sClient for HttpK8sClient {
                     "env": [
                       {
                         "name": "APP_ENVIRONMENT",
-                        "value": "prod"
+                        "value": environment.to_string()
                       },
                       {
                         "name": "APP_SENTRY__DSN",