ref(metrics): Rename metric (#364)

Author: iambriccardo

etl/src/metrics.rs

@@ -7,7 +7,7 @@ static REGISTER_METRICS: Once = Once::new();
 pub const ETL_TABLES_TOTAL: &str = "etl_tables_total";
 pub const ETL_BATCH_ITEMS_WRITTEN_TOTAL: &str = "etl_batch_items_written_total";
 pub const ETL_TABLE_ROWS_TOTAL_WRITTEN: &str = "etl_table_rows_total_written";
-pub const ETL_ITEMS_SEND_DURATION_SECONDS: &str = "etl_items_send_duration_seconds";
+pub const ETL_BATCH_ITEMS_SEND_DURATION_SECONDS: &str = "etl_batch_items_send_duration_seconds";
 pub const ETL_TRANSACTION_DURATION_SECONDS: &str = "etl_transaction_duration_seconds";
 pub const ETL_TRANSACTION_SIZE: &str = "etl_transaction_size";
 pub const ETL_COPIED_TABLE_ROW_SIZE_BYTES: &str = "etl_copied_table_row_size_bytes";
@@ -47,9 +47,9 @@ pub(crate) fn register_metrics() {
         );
 
         describe_histogram!(
-            ETL_ITEMS_SEND_DURATION_SECONDS,
+            ETL_BATCH_ITEMS_SEND_DURATION_SECONDS,
             Unit::Seconds,
-            "Time taken in seconds to send batch items to the destination, labeled by worker_type and action"
+            "Time taken in seconds to send a batch of items to the destination, labeled by worker_type and action"
         );
 
         describe_histogram!(

etl/src/replication/apply.rs

@@ -26,8 +26,8 @@ use crate::conversions::event::{
 use crate::destination::Destination;
 use crate::error::{ErrorKind, EtlResult};
 use crate::metrics::{
-    ACTION_LABEL, DESTINATION_LABEL, ETL_BATCH_ITEMS_WRITTEN_TOTAL,
-    ETL_ITEMS_SEND_DURATION_SECONDS, ETL_TRANSACTION_DURATION_SECONDS, ETL_TRANSACTION_SIZE,
+    ACTION_LABEL, DESTINATION_LABEL, ETL_BATCH_ITEMS_SEND_DURATION_SECONDS,
+    ETL_BATCH_ITEMS_WRITTEN_TOTAL, ETL_TRANSACTION_DURATION_SECONDS, ETL_TRANSACTION_SIZE,
     PIPELINE_ID_LABEL, WORKER_TYPE_LABEL,
 };
 use crate::replication::client::PgReplicationClient;
@@ -755,7 +755,7 @@ where
 
     let send_duration_seconds = before_sending.elapsed().as_secs_f64();
     histogram!(
-        ETL_ITEMS_SEND_DURATION_SECONDS,
+        ETL_BATCH_ITEMS_SEND_DURATION_SECONDS,
         WORKER_TYPE_LABEL => "apply",
         ACTION_LABEL => "table_streaming",
         PIPELINE_ID_LABEL => pipeline_id.to_string(),

etl/src/replication/table_sync.rs

@@ -22,8 +22,8 @@ use crate::failpoints::{
     etl_fail_point,
 };
 use crate::metrics::{
-    ACTION_LABEL, DESTINATION_LABEL, ETL_BATCH_ITEMS_WRITTEN_TOTAL,
-    ETL_ITEMS_SEND_DURATION_SECONDS, ETL_TABLE_ROWS_TOTAL_WRITTEN, PIPELINE_ID_LABEL,
+    ACTION_LABEL, DESTINATION_LABEL, ETL_BATCH_ITEMS_SEND_DURATION_SECONDS,
+    ETL_BATCH_ITEMS_WRITTEN_TOTAL, ETL_TABLE_ROWS_TOTAL_WRITTEN, PIPELINE_ID_LABEL,
     WORKER_TYPE_LABEL,
 };
 use crate::replication::client::PgReplicationClient;
@@ -245,7 +245,7 @@ where
 
                         let send_duration_seconds = before_sending.elapsed().as_secs_f64();
                         histogram!(
-                            ETL_ITEMS_SEND_DURATION_SECONDS,
+                            ETL_BATCH_ITEMS_SEND_DURATION_SECONDS,
                             WORKER_TYPE_LABEL => "table_sync",
                             ACTION_LABEL => "table_copy",
                             PIPELINE_ID_LABEL => pipeline_id.to_string(),