fix: pg_net doesn't support redirects

Author: steve-chavez

nix/nginx/conf/custom.conf

@@ -37,3 +37,11 @@ location /delete {
   }
   echo_duplicate 1 $echo_client_request_headers$is_args$query_string;
 }
+
+location /redirect_me {
+  return 301 /to_here;
+}
+
+location /to_here {
+  echo 'I got redirected';
+}

src/worker.c

@@ -147,6 +147,7 @@ static CURLMcode init(CURLM *cm, char *method, char *url, int timeout_millisecon
 	curl_easy_setopt(eh, CURLOPT_HTTPHEADER, cdata->request_headers);
 	curl_easy_setopt(eh, CURLOPT_TIMEOUT_MS, timeout_milliseconds);
 	curl_easy_setopt(eh, CURLOPT_PRIVATE, cdata);
+	curl_easy_setopt(eh, CURLOPT_FOLLOWLOCATION, true);
 	if (log_min_messages <= DEBUG1)
 		curl_easy_setopt(eh, CURLOPT_VERBOSE, 1L);
 	curl_easy_setopt(eh, CURLOPT_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS);

test/test_http_get_collect.py

@@ -124,3 +124,28 @@ def test_http_get_responses_have_different_created_times(sess):
     )).scalar()
 
     assert count == 3
+
+def test_http_get_collect_with_redirect(sess):
+    """Follows a redirect and collects a response"""
+
+    # Create a request
+    (request_id,) = sess.execute(text(
+        """
+        select net.http_get('http://localhost:8080/redirect_me');
+    """
+    )).fetchone()
+
+    # Commit so background worker can start
+    sess.commit()
+
+    # Collect the response, waiting as needed
+    response = sess.execute(text(
+            """
+        select * from net._http_collect_response(:request_id, async:=false);
+    """
+        ),
+        {"request_id": request_id},
+    ).fetchone()
+
+    assert response is not None
+    assert "I got redirected" in response[2]