Skip to content

Commit 1429ccd

Browse files
committed
fix(ci): skip run-testinfra and run-tests when nix-eval fails
Add nix-eval to needs dependencies and check its result in conditional expressions to prevent downstream test jobs from running when evaluation fails.
1 parent 1d35332 commit 1429ccd

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/nix-build.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,10 @@ jobs:
104104
run: nix build --accept-flake-config -L .#${{ matrix.attr }}
105105

106106
run-testinfra:
107-
needs: [nix-build-aarch64-linux, nix-build-aarch64-darwin, nix-build-x86_64-linux]
107+
needs: [nix-eval, nix-build-aarch64-linux, nix-build-aarch64-darwin, nix-build-x86_64-linux]
108108
if: |
109109
!cancelled() &&
110+
needs.nix-eval.result == 'success' &&
110111
(needs.nix-build-aarch64-linux.result == 'skipped' || needs.nix-build-aarch64-linux.result == 'success') &&
111112
(needs.nix-build-aarch64-darwin.result == 'skipped' || needs.nix-build-aarch64-darwin.result == 'success') &&
112113
(needs.nix-build-x86_64-linux.result == 'skipped' || needs.nix-build-x86_64-linux.result == 'success')
@@ -115,9 +116,10 @@ jobs:
115116
DEV_AWS_ROLE: ${{ secrets.DEV_AWS_ROLE }}
116117

117118
run-tests:
118-
needs: [nix-build-aarch64-linux, nix-build-aarch64-darwin, nix-build-x86_64-linux]
119+
needs: [nix-eval, nix-build-aarch64-linux, nix-build-aarch64-darwin, nix-build-x86_64-linux]
119120
if: |
120-
!cancelled() &&
121+
!cancelled() &&
122+
needs.nix-eval.result == 'success' &&
121123
(needs.nix-build-aarch64-linux.result == 'skipped' || needs.nix-build-aarch64-linux.result == 'success') &&
122124
(needs.nix-build-aarch64-darwin.result == 'skipped' || needs.nix-build-aarch64-darwin.result == 'success') &&
123125
(needs.nix-build-x86_64-linux.result == 'skipped' || needs.nix-build-x86_64-linux.result == 'success')

0 commit comments

Comments
 (0)