chore: account for loose files

Author: pcnc

ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh

@@ -341,7 +341,7 @@ function initiate_upgrade {
         echo "1.2. Installing flake revision: $NIX_FLAKE_VERSION"
         # shellcheck disable=SC1091
         source /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
-        nix-collect-garbage -d > /tmp/pg_upgrade-nix-gc.log 2>&1 || true
+        nix-collect-garbage -d > "${PG_UPGRADE_DIR}/pg_upgrade-nix-gc.log" 2>&1 || true
         PG_UPGRADE_BIN_DIR=$(nix build "github:supabase/postgres/${NIX_FLAKE_VERSION}#psql_15/bin" --no-link --print-out-paths --extra-experimental-features nix-command --extra-experimental-features flakes)
         PGSHARENEW="$PG_UPGRADE_BIN_DIR/share/postgresql"
     fi
@@ -360,10 +360,7 @@ function initiate_upgrade {
 
     chown -R postgres:postgres "$PG_UPGRADE_BIN_DIR"
 
-    # upgrade job outputs a log in the cwd; needs write permissions
-    mkdir -p /tmp/pg_upgrade/
-    chown -R postgres:postgres /tmp/pg_upgrade/
-    cd /tmp/pg_upgrade/
+    cd "$PG_UPGRADE_DIR"
 
     # Fixing erros generated by previous dpkg executions (package upgrades et co)
     echo "2. Fixing potential errors generated by dpkg"
@@ -487,7 +484,7 @@ EOF
     # copy sql files generated by pg_upgrade
     echo "12. Copying sql files generated by pg_upgrade"
     mkdir -p "$MOUNT_POINT/sql"
-    cp /tmp/pg_upgrade/*.sql "$MOUNT_POINT/sql/" || true
+    cp "$PG_UPGRADE_DIR"/pg_upgrade/*.sql "$MOUNT_POINT/sql/" || true
     chown -R postgres:postgres "$MOUNT_POINT/sql/"
 
     echo "13. Cleaning up"