fix: make sure integration tests

do not run timescaledb tests on pg > 15

Author: samrose

nix/ext/tests/default.nix

@@ -10,6 +10,8 @@ let
     let
       pname = extension_name;
       inherit (pkgs) lib;
+      # Special case for timescaledb-apache: only test with PostgreSQL 15
+      isTimescaledb = extension_name == "timescaledb-apache";
       installedExtension =
         postgresMajorVersion: self.packages.${pkgs.system}."psql_${postgresMajorVersion}/exts/${pname}-all";
       versions = postgresqlMajorVersion: (installedExtension postgresqlMajorVersion).versions;
@@ -44,7 +46,8 @@ let
         in
         pkg;
       psql_15 = postgresqlWithExtension self.packages.${pkgs.system}.postgresql_15;
-      psql_17 = postgresqlWithExtension self.packages.${pkgs.system}.postgresql_17;
+      psql_17 =
+        if isTimescaledb then null else postgresqlWithExtension self.packages.${pkgs.system}.postgresql_17;
     in
     self.inputs.nixpkgs.lib.nixos.runTest {
       name = pname;
@@ -80,42 +83,44 @@ let
 
           networking.firewall.allowedTCPPorts = [ config.services.postgresql.settings.port ];
 
-          specialisation.postgresql17.configuration = {
-            services.postgresql = {
-              package = lib.mkForce psql_17;
-            };
+          specialisation = lib.optionalAttrs (!isTimescaledb) {
+            postgresql17.configuration = {
+              services.postgresql = {
+                package = lib.mkForce psql_17;
+              };
 
-            systemd.services.postgresql-migrate = {
-              serviceConfig = {
-                Type = "oneshot";
-                RemainAfterExit = true;
-                User = "postgres";
-                Group = "postgres";
-                StateDirectory = "postgresql";
-                WorkingDirectory = "${builtins.dirOf config.services.postgresql.dataDir}";
+              systemd.services.postgresql-migrate = {
+                serviceConfig = {
+                  Type = "oneshot";
+                  RemainAfterExit = true;
+                  User = "postgres";
+                  Group = "postgres";
+                  StateDirectory = "postgresql";
+                  WorkingDirectory = "${builtins.dirOf config.services.postgresql.dataDir}";
+                };
+                script =
+                  let
+                    oldPostgresql = psql_15;
+                    newPostgresql = psql_17;
+                    oldDataDir = "${builtins.dirOf config.services.postgresql.dataDir}/${oldPostgresql.psqlSchema}";
+                    newDataDir = "${builtins.dirOf config.services.postgresql.dataDir}/${newPostgresql.psqlSchema}";
+                  in
+                  ''
+                    if [[ ! -d ${newDataDir} ]]; then
+                      install -d -m 0700 -o postgres -g postgres "${newDataDir}"
+                      ${newPostgresql}/bin/initdb -D "${newDataDir}"
+                      ${newPostgresql}/bin/pg_upgrade --old-datadir "${oldDataDir}" --new-datadir "${newDataDir}" \
+                        --old-bindir "${oldPostgresql}/bin" --new-bindir "${newPostgresql}/bin"
+                    else
+                      echo "${newDataDir} already exists"
+                    fi
+                  '';
               };
-              script =
-                let
-                  oldPostgresql = psql_15;
-                  newPostgresql = psql_17;
-                  oldDataDir = "${builtins.dirOf config.services.postgresql.dataDir}/${oldPostgresql.psqlSchema}";
-                  newDataDir = "${builtins.dirOf config.services.postgresql.dataDir}/${newPostgresql.psqlSchema}";
-                in
-                ''
-                  if [[ ! -d ${newDataDir} ]]; then
-                    install -d -m 0700 -o postgres -g postgres "${newDataDir}"
-                    ${newPostgresql}/bin/initdb -D "${newDataDir}"
-                    ${newPostgresql}/bin/pg_upgrade --old-datadir "${oldDataDir}" --new-datadir "${newDataDir}" \
-                      --old-bindir "${oldPostgresql}/bin" --new-bindir "${newPostgresql}/bin"
-                  else
-                    echo "${newDataDir} already exists"
-                  fi
-                '';
-            };
 
-            systemd.services.postgresql = {
-              after = [ "postgresql-migrate.service" ];
-              requires = [ "postgresql-migrate.service" ];
+              systemd.services.postgresql = {
+                after = [ "postgresql-migrate.service" ];
+                requires = [ "postgresql-migrate.service" ];
+              };
             };
           };
         };
@@ -127,7 +132,12 @@ let
         ''
           versions = {
             "15": [${lib.concatStringsSep ", " (map (s: ''"${s}"'') (versions "15"))}],
-            "17": [${lib.concatStringsSep ", " (map (s: ''"${s}"'') (versions "17"))}],
+            ${
+              if isTimescaledb then
+                ""
+              else
+                ''"17": [${lib.concatStringsSep ", " (map (s: ''"${s}"'') (versions "17"))}],''
+            }
           }
           extension_name = "${pname}"
           support_upgrade = True
@@ -156,16 +166,22 @@ let
             with subtest("Test switch_${pname}_version"):
               test.check_switch_extension_with_background_worker(Path("${psql_15}/lib/${pname}.so"), "15")
 
-          with subtest("switch to postgresql 17"):
-            server.succeed(
-              f"{pg17_configuration}/bin/switch-to-configuration test >&2"
-            )
+          ${
+            if isTimescaledb then
+              ""
+            else
+              ''
+                with subtest("switch to postgresql 17"):
+                  server.succeed(
+                    f"{pg17_configuration}/bin/switch-to-configuration test >&2"
+                  )
 
-          with subtest("Check last version of the extension after upgrade"):
-            test.assert_version_matches(last_version)
+                with subtest("Check last version of the extension after upgrade"):
+                  test.assert_version_matches(last_version)
 
-          with subtest("Check upgrade path with postgresql 17"):
-            test.check_upgrade_path("17")
+                with subtest("Check upgrade path with postgresql 17"):
+                  test.check_upgrade_path("17")''
+          }
         '';
     };
 in
@@ -186,7 +202,7 @@ builtins.listToAttrs (
       "index_advisor"
       "pg_cron"
       "pg_net"
-      "timescaledb"
+      "timescaledb-apache"
       "vector"
       "wrappers"
     ]