Isolate failing tests on pg17 and OrioleDB (#1402)

* separate pg17 and oriole test diffs

* ignore minor diffs in float value

* update pgmq after-create script for pg 17

* all tests fixed except interface

* sync tests

* move postgis_tiger_geocoder to ext_interface

* align pg 17 extension interface tests

Author: olirice

ansible/files/postgresql_extension_custom_scripts/pgmq/after-create.sql

@@ -2,18 +2,41 @@ do $$
 declare
   extoid oid := (select oid from pg_extension where extname = 'pgmq');
   r record;
+  cls pg_class%rowtype;
 begin
+
   set local search_path = '';
   update pg_extension set extowner = 'postgres'::regrole where extname = 'pgmq';
+
   for r in (select * from pg_depend where refobjid = extoid) loop
+
+
     if r.classid = 'pg_type'::regclass then
-      execute(format('alter type %s owner to postgres;', r.objid::regtype));
+
+      -- store the type's relkind
+      select * into cls from pg_class c where c.reltype = r.objid;
+
+      if r.objid::regtype::text like '%[]' then
+        -- do nothing (skipping array type)
+
+      elsif cls.relkind in ('r', 'p', 'f', 'm') then
+        -- table-like objects (regular table, partitioned, foreign, materialized view)
+        execute format('alter table pgmq.%I owner to postgres;', cls.relname);
+
+      else
+        execute(format('alter type %s owner to postgres;', r.objid::regtype));
+
+      end if;
+
     elsif r.classid = 'pg_proc'::regclass then
       execute(format('alter function %s(%s) owner to postgres;', r.objid::regproc, pg_get_function_identity_arguments(r.objid)));
+
     elsif r.classid = 'pg_class'::regclass then
       execute(format('alter table %s owner to postgres;', r.objid::regclass));
+
     else
       raise exception 'error on pgmq after-create script: unexpected object type %', r.classid;
+
     end if;
   end loop;
 end $$;

flake.nix

@@ -146,11 +146,7 @@
           x: 
             x != ./nix/ext/timescaledb.nix &&
             x != ./nix/ext/timescaledb-2.9.1.nix &&
-            x != ./nix/ext/plv8.nix && 
-            x != ./nix/ext/postgis.nix && 
-            x != ./nix/ext/pgrouting.nix &&
-            x != ./nix/ext/pg_jsonschema.nix &&
-            x != ./nix/ext/pg_graphql.nix 
+            x != ./nix/ext/plv8.nix
         ) ourExtensions;
 
         orioledbExtensions = orioleFilteredExtensions ++ [ ./nix/ext/orioledb.nix ];

nix/tests/expected/pg_tle.out

@@ -1,3 +1,4 @@
+set client_min_messages = warning;
 select
   pgtle.install_extension(
     'pg_distance',
@@ -29,16 +30,16 @@ select
 (1 row)
 
 create extension pg_distance;
-select manhattan_dist(1, 1, 5, 5);
+select manhattan_dist(1, 1, 5, 5)::numeric(10,2);
  manhattan_dist 
 ----------------
-              8
+           8.00
 (1 row)
 
-select euclidean_dist(1, 1, 5, 5);
-  euclidean_dist   
--------------------
- 5.656854249492381
+select euclidean_dist(1, 1, 5, 5)::numeric(10,2);
+ euclidean_dist 
+----------------
+           5.66
 (1 row)
 
 SELECT pgtle.install_update_path(

nix/tests/expected/extensions_sql_interface.out renamed to nix/tests/expected/z_15_ext_interface.out

@@ -1,3 +1,9 @@
+/*
+This test is excluded from the Postgres 17 suite because it does not ship
+with the Supabase PG17 image
+*/
+create extension if not exists plv8;
+NOTICE:  extension "plv8" already exists, skipping
 create schema v;
 -- create a function to perform some JavaScript operations
 create function v.multiply_numbers(a integer, b integer)

nix/tests/expected/pg_stat_monitor.out renamed to nix/tests/expected/z_15_pg_stat_monitor.out

@@ -1,3 +1,6 @@
+/*
+This extension is excluded from oriole-17 because it uses an unsupported index type
+*/
 create schema v;
 create table v.test_rum(
   t text,
@@ -20,18 +23,18 @@ values
 create index rumidx on v.test_rum using rum (a rum_tsvector_ops);
 select
   t,
-  a <=> to_tsquery('english', 'beautiful | place') as rank
+  round(a <=> to_tsquery('english', 'beautiful | place')) as rank
 from
   v.test_rum
 where
   a @@ to_tsquery('english', 'beautiful | place')
 order by
   a <=> to_tsquery('english', 'beautiful | place');
-                t                |   rank   
----------------------------------+----------
- it looks like a beautiful place |  8.22467
- the situation is most beautiful | 16.44934
- it is a beautiful               | 16.44934
+                t                | rank 
+---------------------------------+------
+ it looks like a beautiful place |    8
+ the situation is most beautiful |   16
+ it is a beautiful               |   16
 (3 rows)
 
 drop schema v cascade;

nix/tests/expected/pgroonga.out renamed to nix/tests/expected/z_15_pgroonga.out

@@ -1,3 +1,9 @@
+/*
+This test is excluded from the Postgres 17 suite because it does not ship
+with the Supabase PG17 image
+*/
+create extension if not exists timescaledb;
+NOTICE:  extension "timescaledb" already exists, skipping
 -- Confirm we're running the apache version
 show timescaledb.license;
  timescaledb.license