fix: replace deprecated v8 package, and wrong packages arguments

Author: yvan-sraka

nix/ext/plv8/default.nix

@@ -2,7 +2,7 @@
   stdenv,
   lib,
   fetchFromGitHub,
-  v8,
+  # v8,
   perl,
   postgresql,
   # For passthru test on various systems, and local development on macos
@@ -36,13 +36,22 @@ let
     lib.mapAttrs (name: value: build name value.hash) supportedVersions
   );
 
+  # plv8 3.1 requires an older version of v8 (we cannot use nodejs.libv8)
+  node_pkgs = import (fetchTarball {
+    url = "https://github.com/nixos/nixpkgs/archive/a76c4553d7e741e17f289224eda135423de0491d.tar.gz";
+    sha256 = "0rwdzp942b8ay625lqgra83qrp64b3wqm6w9a0i4z593df8x822v";
+  }) { system = stdenv.system; };
+  inherit (node_pkgs) v8;
+
   # Build function for individual versions
   build =
     version: hash:
     stdenv.mkDerivation (finalAttrs: {
       inherit pname version;
       #version = "3.1.10";
 
+      v8 = (if (builtins.compareVersions "3.1.10" version >= 0) then v8 else nodejs_20.libv8);
+
       src = fetchFromGitHub {
         owner = "plv8";
         repo = "plv8";

nix/postgresql/generic.nix

@@ -65,6 +65,8 @@ let
       # detection of crypt fails when using llvm stdenv, so we add it manually
       # for <13 (where it got removed: https://github.com/postgres/postgres/commit/c45643d618e35ec2fe91438df15abd4f3c0d85ca)
       libxcrypt,
+
+      isOrioleDB ? (builtins.match "[0-9][0-9]_.*" version) != null,
     }@args:
     let
       atLeast = lib.versionAtLeast version;
@@ -78,8 +80,6 @@ let
         else
           (lib.warn "postgresql: argument enableSystemd is deprecated, please use systemdSupport instead." enableSystemd);
 
-      isOrioleDB = (builtins.match "[0-9][0-9]_.*" version) != null;
-
       pname = "postgresql";
 
       stdenv' = if jitSupport then llvmPackages.stdenv else stdenv;