Skip to content

Commit faf337a

Browse files
committed
docs: add some notes about the workflow ordering
1 parent db21821 commit faf337a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/ami-release-nix.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,12 @@ jobs:
126126
# aws s3 cp /tmp/pg_binaries.tar.gz s3://${{ secrets.ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/20.04.tar.gz
127127
# #TODO look to see if this only pg binaries and if so, remove this as it is covered by nix build
128128
# TODO deactivate this block to assure binaries from this file are not uploaded. This is covered by nix build
129+
130+
#Our self hosted github runner already has permissions to publish images
131+
#but they're limited to only that;
132+
#so if we want s3 access we'll need to config credentials with the below steps
133+
# (which overwrites existing perms) after the ami build
134+
129135
- name: configure aws credentials - prod
130136
uses: aws-actions/configure-aws-credentials@v4
131137
with:

0 commit comments

Comments
 (0)