nix/ext/tests/pg_plan_filter.nix (1)

62-66: Change installedExtension version to match PostgreSQL 17 in line 65.

Line 65 uses (installedExtension "15").defaultSettings for the PostgreSQL 17 configuration, but should use "17" to match the version being configured. This is inconsistent with correct patterns in pgjwt.nix line 87 and default.nix line 94, which both use (installedExtension "17").defaultSettings for their postgresql17 specialisations.

nix/ext/tests/http.nix (2)

5-9: Inconsistent host platform reference will break Darwin builds.

installedExtension uses pkgs.stdenv.hostPlatform.system while other parts of this file (lines 15, 30, 62, 79, 82) use pkgs.pkgsLinux.stdenv.hostPlatform.system. On Darwin, this resolves to aarch64-darwin vs aarch64-linux, causing a mismatch where the extension lookup targets Darwin packages but the build environment is Linux.

Other test files in this PR (e.g., pg_repack.nix, plpgsql_check.nix, pgmq.nix) consistently use pkgs.pkgsLinux for this lookup.

Proposed fix

   installedExtension =
     postgresMajorVersion:
-    self.legacyPackages.${pkgs.stdenv.hostPlatform.system}."psql_${postgresMajorVersion}".exts."${
+    self.legacyPackages.${pkgs.pkgsLinux.stdenv.hostPlatform.system}."psql_${postgresMajorVersion}".exts."${
       pname
     }";

---

54-57: Inconsistent host platform reference for PostgreSQL 15.

Line 56 uses pkgs.stdenv.hostPlatform.system while the PostgreSQL 17 reference at line 62 uses pkgs.pkgsLinux.stdenv.hostPlatform.system. This inconsistency will cause version mismatch issues on Darwin hosts.

Proposed fix

       services.postgresql = {
         enable = true;
-        package = postgresqlWithExtension self.packages.${pkgs.stdenv.hostPlatform.system}.postgresql_15;
+        package = postgresqlWithExtension self.packages.${pkgs.pkgsLinux.stdenv.hostPlatform.system}.postgresql_15;
       };

nix/ext/tests/default.nix (1)

13-38: Align installedExtension to the Linux package set to avoid platform mismatch.

psql_15 and psql_17 resolve packages from pkgs.pkgsLinux.stdenv.hostPlatform.system, but installedExtension uses pkgs.stdenv.hostPlatform.system. On aarch64‑darwin, this resolves to the Darwin platform while the extensions are then mixed into a Linux buildEnv (line 23), causing cross-platform package incompatibilities. Change line 15 to use pkgs.pkgsLinux.stdenv.hostPlatform.system to keep all lookups within the same package set.

🧩 Proposed fix

-      self.legacyPackages.${pkgs.stdenv.hostPlatform.system}."psql_${postgresMajorVersion}".exts."${
+      self.legacyPackages.${pkgs.pkgsLinux.stdenv.hostPlatform.system}."psql_${postgresMajorVersion}".exts."${
         pname
       }";