wip: returns vs returns setof rows 1

explore bug a bit: PostgREST/postgrest#4232

Author: avallete

test/advanced_rpc.test.ts

@@ -154,23 +154,21 @@ describe('advanced rpc', () => {
       },
     })
     let result: Exclude<typeof res.data, null>
-    let expected: z.infer<typeof UserProfileSchema>[]
+    let expected: z.infer<typeof UserProfileSchema>
     expectType<TypeEqual<typeof result, typeof expected>>(true)
     expect(res).toMatchInlineSnapshot(`
       Object {
         "count": null,
-        "data": Array [
-          Object {
-            "id": 1,
-            "username": "supabot",
-          },
-        ],
+        "data": Object {
+          "id": 1,
+          "username": "supabot",
+        },
         "error": null,
         "status": 200,
         "statusText": "OK",
       }
     `)
-    UserProfileSchema.array().parse(res.data)
+    UserProfileSchema.parse(res.data)
   })
 
   test('function with scalar input', async () => {
@@ -505,16 +503,14 @@ describe('advanced rpc', () => {
     expect(res).toMatchInlineSnapshot(`
       Object {
         "count": null,
-        "data": Array [
-          Object {
-            "id": 1,
+        "data": Object {
+          "id": 1,
+          "username": "supabot",
+          "users": Object {
+            "catchphrase": "'cat' 'fat'",
             "username": "supabot",
-            "users": Object {
-              "catchphrase": "'cat' 'fat'",
-              "username": "supabot",
-            },
           },
-        ],
+        },
         "error": null,
         "status": 200,
         "statusText": "OK",
@@ -536,7 +532,7 @@ describe('advanced rpc', () => {
     expect(res).toMatchInlineSnapshot(`
       Object {
         "count": null,
-        "data": Array [],
+        "data": null,
         "error": null,
         "status": 200,
         "statusText": "OK",
@@ -554,7 +550,7 @@ describe('advanced rpc', () => {
     expect(res2).toMatchInlineSnapshot(`
       Object {
         "count": null,
-        "data": Array [],
+        "data": null,
         "error": null,
         "status": 200,
         "statusText": "OK",
@@ -572,15 +568,13 @@ describe('advanced rpc', () => {
     expect(res3).toMatchInlineSnapshot(`
       Object {
         "count": null,
-        "data": Array [
-          Object {
+        "data": Object {
+          "username": "supabot",
+          "users": Object {
+            "catchphrase": "'cat' 'fat'",
             "username": "supabot",
-            "users": Object {
-              "catchphrase": "'cat' 'fat'",
-              "username": "supabot",
-            },
           },
-        ],
+        },
         "error": null,
         "status": 200,
         "statusText": "OK",

test/db/00-schema.sql

@@ -170,11 +170,10 @@ create table public.cornercase (
 
 -- Function that returns a single user profile for a user
 CREATE OR REPLACE FUNCTION public.get_user_profile(user_row users)
-RETURNS SETOF user_profiles
+RETURNS user_profiles
 LANGUAGE SQL STABLE
-ROWS 1
 AS $$
-  SELECT * FROM public.user_profiles WHERE username = user_row.username;
+  SELECT * FROM public.user_profiles WHERE username = user_row.username LIMIT 1;
 $$;
 
 -- Same definition, but will be used with a type override to pretend this can't ever return null

test/embeded_functions_join.test.ts

@@ -357,19 +357,31 @@ describe('embeded functions select', () => {
             "username": "supabot",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "id": null,
+              "username": null,
+            },
             "username": "kiwicopple",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "id": null,
+              "username": null,
+            },
             "username": "awailas",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "id": null,
+              "username": null,
+            },
             "username": "jsonuser",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "id": null,
+              "username": null,
+            },
             "username": "dragarcia",
           },
         ],
@@ -479,19 +491,27 @@ describe('embeded functions select', () => {
             "username": "supabot",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "username": null,
+            },
             "username": "kiwicopple",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "username": null,
+            },
             "username": "awailas",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "username": null,
+            },
             "username": "jsonuser",
           },
           Object {
-            "user_called_profile": null,
+            "user_called_profile": Object {
+              "username": null,
+            },
             "username": "dragarcia",
           },
         ],

test/types.generated.ts

@@ -708,7 +708,7 @@ export type Database = {
         Returns: {
           id: number
           username: string | null
-        }[]
+        }
         SetofOptions: {
           from: 'users'
           to: 'user_profiles'