perf: nullsFirst = true by default

soedirgo · soedirgo · commit 586e6cdff7c8 · 2022-08-05T17:10:29.000+08:00
BREAKING CHANGE: nullsFirst = true by default We previously set `nullsFirst = false` by default, but it caused some perf issues: #239
diff --git a/src/PostgrestTransformBuilder.ts b/src/PostgrestTransformBuilder.ts
@@ -46,7 +46,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
     column: keyof T,
     {
       ascending = true,
-      nullsFirst = false,
+      nullsFirst = true,
       foreignTable,
     }: { ascending?: boolean; nullsFirst?: boolean; foreignTable?: string } = {}
   ): this {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {`
`46`	`46`	`column: keyof T,`
`47`	`47`	`{`
`48`	`48`	`ascending = true,`
`49`		`- nullsFirst = false,`
	`49`	`+ nullsFirst = true,`
`50`	`50`	`foreignTable,`
`51`	`51`	`}: { ascending?: boolean; nullsFirst?: boolean; foreignTable?: string } = {}`
`52`	`52`	`): this {`