Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Commit 5e442ad

Browse files
committed
#51 Remove redundant options for all except INSERT
1 parent ad3aa17 commit 5e442ad

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

src/Builder.js

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,7 @@ class Builder {
3333
return new Request(method, this.url, this.headers)
3434
}
3535

36-
addFilters(request, options) {
37-
if (Object.keys(options).length != 0) {
38-
Object.keys(options).forEach((option) => {
39-
let setting = options[option]
40-
request.set(option, setting)
41-
})
42-
}
43-
36+
addFilters(request) {
4437
// loop through this.queryFilters
4538
this.queryFilters.forEach((queryFilter) => {
4639
switch (queryFilter.filter) {
@@ -163,12 +156,12 @@ class Builder {
163156
/**
164157
* Start a "GET" request
165158
*/
166-
select(columnQuery = '*', options = {}) {
159+
select(columnQuery = '*') {
167160
let method = 'GET'
168161
let request = this.request(method)
169162

170163
request.select(columnQuery)
171-
this.addFilters(request, options)
164+
this.addFilters(request)
172165

173166
return request
174167
}
@@ -186,15 +179,15 @@ class Builder {
186179
request.set('Prefer', header)
187180
request.send(data)
188181

189-
this.addFilters(request, options)
182+
this.addFilters(request)
190183

191184
return request
192185
}
193186

194187
/**
195188
* Start a "PATCH" request
196189
*/
197-
update(data, options = {}) {
190+
update(data) {
198191
let method = 'PATCH'
199192
let request = this.request(method)
200193

@@ -210,19 +203,19 @@ class Builder {
210203
request.set('Prefer', 'return=representation')
211204
request.send(data)
212205

213-
this.addFilters(request, options)
206+
this.addFilters(request)
214207

215208
return request
216209
}
217210

218211
/**
219212
* Start a "DELETE" request
220213
*/
221-
delete(options = {}) {
214+
delete() {
222215
let method = 'DELETE'
223216
let request = this.request(method)
224217

225-
this.addFilters(request, options)
218+
this.addFilters(request)
226219

227220
return request
228221
}

0 commit comments

Comments
 (0)