Skip to content

Commit 3c5ea35

Browse files
authored
fix: properly export log level (#464)
1 parent 2ee9199 commit 3c5ea35

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

src/RealtimeClient.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
TRANSPORTS,
1010
VSN,
1111
WS_CLOSE_NORMAL,
12-
LOG_LEVEL,
1312
} from './lib/constants'
1413

1514
import Serializer from './lib/serializer'
@@ -27,7 +26,7 @@ export type Channel = {
2726
updated_at: string
2827
id: number
2928
}
30-
export type LogLevel = LOG_LEVEL
29+
export type LogLevel = 'info' | 'warn' | 'error'
3130

3231
export type RealtimeMessage = {
3332
topic: string

src/lib/constants.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,3 @@ export enum CONNECTION_STATE {
4444
Closing = 'closing',
4545
Closed = 'closed',
4646
}
47-
48-
export enum LOG_LEVEL {
49-
Info = 'info',
50-
Warn = 'warn',
51-
Error = 'error',
52-
}

test/client.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import RealtimeClient, {
1010
RealtimeMessage,
1111
} from '../src/RealtimeClient'
1212
import jwt from 'jsonwebtoken'
13-
import { CHANNEL_STATES, LOG_LEVEL } from '../src/lib/constants'
13+
import { CHANNEL_STATES } from '../src/lib/constants'
1414

1515
function generateJWT(exp: string): string {
1616
return jwt.sign({}, 'your-256-bit-secret', {
@@ -817,18 +817,18 @@ describe('log operations', () => {
817817
})
818818
})
819819
test('changing log_level sends proper params in URL', () => {
820-
socket = new RealtimeClient(url, { log_level: LOG_LEVEL.Warn })
820+
socket = new RealtimeClient(url, { log_level: 'warn' })
821821

822-
assert.equal(socket.logLevel, LOG_LEVEL.Warn)
822+
assert.equal(socket.logLevel, 'warn')
823823
assert.equal(
824824
socket.endpointURL(),
825825
`${url}/websocket?log_level=warn&vsn=1.0.0`
826826
)
827827
})
828828
test('changing logLevel sends proper params in URL', () => {
829-
socket = new RealtimeClient(url, { logLevel: LOG_LEVEL.Warn })
829+
socket = new RealtimeClient(url, { logLevel: 'warn' })
830830

831-
assert.equal(socket.logLevel, LOG_LEVEL.Warn)
831+
assert.equal(socket.logLevel, 'warn')
832832
assert.equal(
833833
socket.endpointURL(),
834834
`${url}/websocket?log_level=warn&vsn=1.0.0`

0 commit comments

Comments
 (0)