Skip to content

Commit d3346ce

Browse files
authored
Merge pull request #148 from supabase/hi/fix-handleError
fix: unhandled promise error when response has invalid json format
2 parents a661d5a + f2c0735 commit d3346ce

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/lib/fetch.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,14 @@ const handleError = async (error: unknown, reject: (reason?: any) => void) => {
2020
const Res = await resolveResponse()
2121

2222
if (error instanceof Res) {
23-
error.json().then((err) => {
24-
reject(new StorageApiError(_getErrorMessage(err), error.status || 500))
25-
})
23+
error
24+
.json()
25+
.then((err) => {
26+
reject(new StorageApiError(_getErrorMessage(err), error.status || 500))
27+
})
28+
.catch((err) => {
29+
reject(new StorageUnknownError(_getErrorMessage(err), err))
30+
})
2631
} else {
2732
reject(new StorageUnknownError(_getErrorMessage(error), error))
2833
}

0 commit comments

Comments
 (0)