Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Commit b43434f

Browse files
refactor: remove create_signed_urls
1 parent 9b967ce commit b43434f

File tree

3 files changed

+3
-25
lines changed

3 files changed

+3
-25
lines changed

storage3/_async/file_api.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -74,17 +74,6 @@ async def create_signed_url(
7474
] = f"{self._client.base_url}{cast(str, data['signedURL']).lstrip('/')}"
7575
return data
7676

77-
async def create_signed_urls(
78-
self, paths: List[str], expires_in: int, options: dict[str, str]
79-
) -> dict[str, str]:
80-
response = await self._request(
81-
"POST",
82-
f"/object/sign/{self.bucket_id}",
83-
json={"expires_in": expires_in, "paths": paths},
84-
)
85-
return response.json()
86-
87-
8877
async def get_public_url(self, path: str, options: TransformOptions = {}) -> str:
8978
"""
9079
Parameters

storage3/_sync/file_api.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -74,19 +74,6 @@ def create_signed_url(
7474
] = f"{self._client.base_url}{cast(str, data['signedURL']).lstrip('/')}"
7575
return data
7676

77-
def create_signed_urls(
78-
self, paths: List[str], expires_in: int, options: dict[str, str]
79-
) -> dict[str, str]:
80-
response = self._request(
81-
"POST",
82-
f"/object/sign/{self.bucket_id}",
83-
json={"expires_in": expires_in, "paths": paths},
84-
)
85-
# TODO(joel): add support for download option
86-
return response.json()
87-
88-
pass
89-
9077
def get_public_url(self, path: str, options: TransformOptions = {}) -> str:
9178
"""
9279
Parameters

tests/_sync/test_client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ def bucket(storage: SyncStorageClient, uuid_factory: Callable[[], str]) -> str:
7979

8080

8181
@pytest.fixture(scope="module")
82-
def public_bucket(storage: SyncStorageClient, uuid_factory: Callable[[], str]) -> str:
82+
def public_bucket(
83+
storage: SyncStorageClient, uuid_factory: Callable[[], str]
84+
) -> str:
8385
"""Creates a test public bucket which will be used in the whole storage tests run and deleted at the end"""
8486
bucket_id = uuid_factory()
8587

0 commit comments

Comments
 (0)