chore: test create_signed_upload_url

Author: anand2312

storage3/_async/file_api.py

@@ -67,7 +67,7 @@ async def create_signed_upload_url(self, path: str) -> SignedUploadURL:
         response = await self._request("POST", f"/object/upload/sign/{_path}")
         data = response.json()
         full_url: urllib.parse.ParseResult = urllib.parse.urlparse(
-            self._client.base_url + data["url"]
+            str(self._client.base_url) + data["url"]
         )
         query_params = urllib.parse.parse_qs(full_url.query)
         if not query_params.get("token"):

storage3/_sync/file_api.py

@@ -67,7 +67,7 @@ def create_signed_upload_url(self, path: str) -> SignedUploadURL:
         response = self._request("POST", f"/object/upload/sign/{_path}")
         data = response.json()
         full_url: urllib.parse.ParseResult = urllib.parse.urlparse(
-            self._client.base_url + data["url"]
+            str(self._client.base_url) + data["url"]
         )
         query_params = urllib.parse.parse_qs(full_url.query)
         if not query_params.get("token"):

tests/_async/test_client.py

@@ -223,6 +223,20 @@ async def test_client_upload(
     assert image_info.get("metadata", {}).get("mimetype") == file.mime_type
 
 
+@pytest.mark.parametrize(
+    "path", ["foobar.txt", "example/nested.jpg", "/leading/slash.png"]
+)
+async def test_client_create_signed_upload_url(
+    storage_file_client: AsyncBucketProxy, path: str
+) -> None:
+    """Ensure we can create signed URLs to upload files to a bucket"""
+    data = await storage_file_client.create_signed_upload_url(path)
+    assert data["path"] == path
+    assert data["token"]
+    expected_url = f"{storage_file_client._client.base_url}/object/upload/sign/{storage_file_client.id}/{path.lstrip('/')}"
+    assert data["signed_url"].startswith(expected_url)
+
+
 async def test_client_create_signed_url(
     storage_file_client: AsyncBucketProxy, file: FileForTesting
 ) -> None:

tests/_sync/test_client.py

@@ -221,6 +221,20 @@ def test_client_upload(
     assert image_info.get("metadata", {}).get("mimetype") == file.mime_type
 
 
+@pytest.mark.parametrize(
+    "path", ["foobar.txt", "example/nested.jpg", "/leading/slash.png"]
+)
+def test_client_create_signed_upload_url(
+    storage_file_client: SyncBucketProxy, path: str
+) -> None:
+    """Ensure we can create signed URLs to upload files to a bucket"""
+    data = storage_file_client.create_signed_upload_url(path)
+    assert data["path"] == path
+    assert data["token"]
+    expected_url = f"{storage_file_client._client.base_url}/object/upload/sign/{storage_file_client.id}/{path.lstrip('/')}"
+    assert data["signed_url"].startswith(expected_url)
+
+
 def test_client_create_signed_url(
     storage_file_client: SyncBucketProxy, file: FileForTesting
 ) -> None: