fix: limit start, end whitespace in bucket name (#699)

* fix: limit start, end whitespace in bucket name

Bucket names shouldn't start or end with spaces to avoid name confusion

* fix: move check to createBucket

* fix: run with matching prettier version

* fix: build failure

Author: staaldraad

src/storage/storage.ts

@@ -86,6 +86,11 @@ export class Storage {
       allowedMimeTypes?: null | string[]
     }
   ) {
+    // prevent creation with leading or trailing whitespace
+    if (data.name.trim().length !== data.name.length) {
+      throw ERRORS.InvalidBucketName(data.name)
+    }
+
     mustBeValidBucketName(data.name)
 
     const bucketData: Parameters<Database['createBucket']>[0] = data

src/test/bucket.test.ts

@@ -234,6 +234,23 @@ describe('testing POST bucket', () => {
     })
     expect(response.statusCode).toBe(400)
   })
+
+  test('user is not able to create a bucket with the leading and trailing spaces', async () => {
+    const response = await appInstance.inject({
+      method: 'POST',
+      url: `/bucket`,
+      headers: {
+        authorization: `Bearer ${process.env.AUTHENTICATED_KEY}`,
+      },
+      payload: {
+        name: ' startsWithSpace',
+      },
+    })
+    expect(response.statusCode).toBe(400)
+    const { statusCode, error } = await response.json()
+    expect(statusCode).toBe('400')
+    expect(error).toBe('Invalid Input')
+  })
 })
 
 /*