Skip to content

Commit aa8c58b

Browse files
authored
fix: queue hours default env (#513)
1 parent 7376f97 commit aa8c58b

File tree

6 files changed

+14
-7
lines changed

6 files changed

+14
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
3838
- name: Prettier checks
3939
run: |
40-
npm run prettier:check
40+
npm run lint
4141
4242
- name: ESLint checks
4343
run: |

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
"dev": "tsx watch src/start/server.ts | pino-pretty",
88
"build": "node ./build.js && resolve-tspaths",
99
"start": "NODE_ENV=production node dist/start/server.js",
10-
"migration:run": "tsx ./src/scripts/migrate-call.ts",
10+
"format": "prettier -c --write src/**",
11+
"lint": "prettier -v && prettier -c src/**",
12+
"migration:run": "tsx src/scripts/migrate.ts",
1113
"docs:export": "tsx ./src/scripts/export-docs.ts",
1214
"test:dummy-data": "tsx -r dotenv/config ./src/test/db/import-dummy-data.ts",
1315
"test": "npm run infra:restart && npm run test:dummy-data && jest --runInBand --forceExit",
1416
"test:coverage": "npm run infra:restart && npm run test:dummy-data && jest --runInBand --coverage --forceExit",
15-
"prettier:check": "prettier -v && prettier -c src/**",
16-
"format": "prettier -c --write src/**",
1717
"eslint:check": "eslint 'src/**'",
1818
"infra:stop": "docker compose --project-directory . -f ./.docker/docker-compose-infra.yml down --remove-orphans",
1919
"infra:start": "docker compose --project-directory . -f ./.docker/docker-compose-infra.yml up -d && sleep 5 && npm run migration:run",

src/internal/queue/event.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ interface BaseEventConstructor<Base extends Event<any>> {
3737
getWorkerOptions(): WorkOptions | BatchWorkOptions
3838
}
3939

40+
/**
41+
* Base class for all events that are sent to the queue
42+
*/
4043
export abstract class Event<T extends Omit<BasePayload, '$version'>> {
4144
public static readonly version: string = 'v1'
4245
protected static queueName = ''

src/internal/queue/queue.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ export abstract class Queue {
5353
url = multitenantDatabaseUrl
5454
}
5555

56+
console.log({
57+
deleteAfterDays: pgQueueDeleteAfterDays,
58+
deleteAfterHours: pgQueueDeleteAfterHours,
59+
})
5660
Queue.pgBoss = new PgBoss({
5761
connectionString: url,
5862
db: new QueueDB({
@@ -63,7 +67,7 @@ export abstract class Queue {
6367
}),
6468
application_name: 'storage-pgboss',
6569
deleteAfterDays: pgQueueDeleteAfterHours ? undefined : pgQueueDeleteAfterDays,
66-
deleteAfterHours: pgQueueDeleteAfterHours,
70+
...(pgQueueDeleteAfterHours ? { deleteAfterHours: pgQueueDeleteAfterHours } : {}),
6771
archiveCompletedAfterSeconds: pgQueueArchiveCompletedAfterSeconds,
6872
retentionDays: pgQueueRetentionDays,
6973
retryBackoff: true,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import dotenv from 'dotenv'
22
dotenv.config()
33

4-
import { runMigrationsOnTenant } from '../internal/database'
4+
import { runMigrationsOnTenant } from '@internal/database'
55
;(async () => {
66
await runMigrationsOnTenant(process.env.DATABASE_URL as string)
77
})()

src/storage/events/base-event.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Event as QueueBaseEvent, BasePayload, StaticThis, Event } from '@intern
22
import { getPostgresConnection, getServiceKeyUser } from '@internal/database'
33
import { StorageKnexDB } from '../database'
44
import { createAgent, createStorageBackend } from '../backend'
5-
import { Storage } from '../index'
5+
import { Storage } from '../storage'
66
import { getConfig } from '../../config'
77
import { logger } from '@internal/monitoring'
88

0 commit comments

Comments
 (0)