fix failing tests

Author: dshukertjr

packages/supabase_flutter/test/deep_link_test.dart

@@ -2,6 +2,7 @@
 
 import 'package:app_links/app_links.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:shared_preferences/shared_preferences.dart';
 import 'package:supabase_flutter/supabase_flutter.dart';
 
 import 'widget_test_stubs.dart';
@@ -80,6 +81,7 @@ void main() {
 
   group('Deep Link Error Handling', () {
     setUp(() {
+      SharedPreferences.setMockInitialValues({});
       mockAppLink();
     });
 

packages/supabase_flutter/test/oauth_test.dart

@@ -60,7 +60,7 @@ void main() {
         final result = await Supabase.instance.client.auth.getOAuthSignInUrl(
           provider: provider,
         );
-        
+
         expect(result.url, isNotNull);
         expect(result.url, contains(provider.name));
       }
@@ -99,9 +99,12 @@ void main() {
   });
 
   group('SSO Authentication', () {
+    late MockSSOHttpClient httpClient;
+
     setUp(() {
       SharedPreferences.setMockInitialValues({});
       mockAppLink();
+      httpClient = MockSSOHttpClient();
     });
 
     tearDown(() async {
@@ -116,6 +119,7 @@ void main() {
       await Supabase.initialize(
         url: supabaseUrl,
         anonKey: supabaseKey,
+        httpClient: httpClient,
       );
 
       final result = await Supabase.instance.client.auth.getSSOSignInUrl(
@@ -131,6 +135,7 @@ void main() {
       await Supabase.initialize(
         url: supabaseUrl,
         anonKey: supabaseKey,
+        httpClient: httpClient,
       );
 
       const redirectUrl = 'myapp://sso/callback';
@@ -147,6 +152,7 @@ void main() {
       await Supabase.initialize(
         url: supabaseUrl,
         anonKey: supabaseKey,
+        httpClient: httpClient,
       );
 
       final result = await Supabase.instance.client.auth.getSSOSignInUrl(
@@ -162,6 +168,7 @@ void main() {
       await Supabase.initialize(
         url: supabaseUrl,
         anonKey: supabaseKey,
+        httpClient: httpClient,
       );
 
       final result = await Supabase.instance.client.auth.getSSOSignInUrl(
@@ -173,28 +180,31 @@ void main() {
       expect(result, contains('provider_id=provider-uuid-123'));
     });
 
-    test('getSSOSignInUrl handles both domain and providerId preference', () async {
+    test(
+        'getSSOSignInUrl includes both domain and providerId when both provided',
+        () async {
       await Supabase.initialize(
         url: supabaseUrl,
         anonKey: supabaseKey,
+        httpClient: httpClient,
       );
 
-      // When both are provided, providerId should take precedence
+      // When both are provided, both should be included in the URL
       final result = await Supabase.instance.client.auth.getSSOSignInUrl(
         domain: 'company.com',
         providerId: 'provider-uuid-456',
       );
 
       expect(result, isNotNull);
       expect(result, contains('provider_id=provider-uuid-456'));
-      // Domain should not be in URL when providerId is provided
-      expect(result, isNot(contains('domain=company.com')));
+      expect(result, contains('domain=company.com'));
     });
 
     test('getSSOSignInUrl validates input parameters', () async {
       await Supabase.initialize(
         url: supabaseUrl,
         anonKey: supabaseKey,
+        httpClient: httpClient,
       );
 
       // Should throw when neither domain nor providerId is provided
@@ -204,4 +214,4 @@ void main() {
       );
     });
   });
-}
+}

packages/supabase_flutter/test/widget_test_stubs.dart

@@ -152,6 +152,60 @@ class MockAsyncStorage extends GotrueAsyncStorage {
   }
 }
 
+/// Custom HTTP client just to test the SSO flow.
+class MockSSOHttpClient extends BaseClient {
+  @override
+  Future<StreamedResponse> send(BaseRequest request) async {
+    final uri = request.url;
+
+    // Mock SSO response
+    if (uri.path.contains('/sso')) {
+      String domain = '';
+      String providerId = '';
+      String redirectTo = '';
+
+      // Extract parameters from request body if it's a POST request
+      if (request is Request && request.body.isNotEmpty) {
+        final body = jsonDecode(request.body) as Map<String, dynamic>;
+        domain = body['domain'] ?? '';
+        providerId = body['provider_id'] ?? '';
+        redirectTo = body['redirect_to'] ?? '';
+      }
+
+      // Construct a mock SSO URL with all parameters
+      var ssoUrl = 'https://test.supabase.co/auth/v1/sso?';
+      if (domain.isNotEmpty) {
+        ssoUrl += 'domain=$domain&';
+      }
+      if (providerId.isNotEmpty) {
+        ssoUrl += 'provider_id=$providerId&';
+      }
+      if (redirectTo.isNotEmpty) {
+        ssoUrl += 'redirect_to=${Uri.encodeComponent(redirectTo)}&';
+      }
+      // Remove trailing & if present
+      if (ssoUrl.endsWith('&')) {
+        ssoUrl = ssoUrl.substring(0, ssoUrl.length - 1);
+      }
+
+      return StreamedResponse(
+        Stream.value(
+          utf8.encode(
+            jsonEncode({'url': ssoUrl}),
+          ),
+        ),
+        200,
+      );
+    }
+
+    // Default response for other requests
+    return StreamedResponse(
+      Stream.value(utf8.encode(jsonEncode({}))),
+      200,
+    );
+  }
+}
+
 /// Custom HTTP client just to test the PKCE flow.
 class PkceHttpClient extends BaseClient {
   int requestCount = 0;
@@ -256,9 +310,10 @@ class MockOAuthHttpClient extends BaseClient {
       final provider = queryParams['provider'] ?? '';
       final redirectTo = queryParams['redirect_to'] ?? '';
       final scopes = queryParams['scopes'] ?? '';
-      
-      final responseUrl = 'https://test.supabase.co/auth/v1/authorize?provider=$provider&redirect_to=${Uri.encodeComponent(redirectTo)}&scopes=${Uri.encodeComponent(scopes)}';
-      
+
+      final responseUrl =
+          'https://test.supabase.co/auth/v1/authorize?provider=$provider&redirect_to=${Uri.encodeComponent(redirectTo)}&scopes=${Uri.encodeComponent(scopes)}';
+
       return StreamedResponse(
         Stream.value(utf8.encode(jsonEncode({'url': responseUrl}))),
         200,
@@ -272,7 +327,7 @@ class MockOAuthHttpClient extends BaseClient {
       final domain = body['domain'] ?? '';
       final providerId = body['provider_id'] ?? '';
       final redirectTo = body['redirect_to'] ?? '';
-      
+
       var responseUrl = 'https://test.supabase.co/auth/v1/sso?';
       if (providerId.isNotEmpty) {
         responseUrl += 'provider_id=${Uri.encodeComponent(providerId)}';
@@ -282,7 +337,7 @@ class MockOAuthHttpClient extends BaseClient {
       if (redirectTo.isNotEmpty) {
         responseUrl += '&redirect_to=${Uri.encodeComponent(redirectTo)}';
       }
-      
+
       return StreamedResponse(
         Stream.value(utf8.encode(jsonEncode({'url': responseUrl}))),
         200,