From b36c5b81eaf5dcb494366979fd33a876c255510f Mon Sep 17 00:00:00 2001 From: felixkamau Date: Thu, 10 Jul 2025 22:15:57 +0300 Subject: [PATCH 1/2] refactor: remove unnecessary parentheses in fromJson constructors --- packages/storage_client/lib/src/types.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/storage_client/lib/src/types.dart b/packages/storage_client/lib/src/types.dart index 1f7647c82..7bd496e8c 100644 --- a/packages/storage_client/lib/src/types.dart +++ b/packages/storage_client/lib/src/types.dart @@ -27,7 +27,7 @@ class Bucket { }); Bucket.fromJson(Map json) - : id = (json)['id'] as String, + : id = json['id'] as String, name = json['name'] as String, owner = json['owner'] as String, createdAt = json['created_at'] as String, From ee63fc92ea3701a4b650a74e9940269225632c10 Mon Sep 17 00:00:00 2001 From: felixkamau Date: Mon, 21 Jul 2025 14:14:10 +0300 Subject: [PATCH 2/2] refactor: Simplify httpClient conditional logic using ternary operator --- packages/storage_client/lib/src/fetch.dart | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/storage_client/lib/src/fetch.dart b/packages/storage_client/lib/src/fetch.dart index 7362a2983..6102b3980 100644 --- a/packages/storage_client/lib/src/fetch.dart +++ b/packages/storage_client/lib/src/fetch.dart @@ -82,11 +82,15 @@ class Fetch { _log.finest('Request: $method $url $headers'); final http.StreamedResponse streamedResponse; - if (httpClient != null) { - streamedResponse = await httpClient!.send(request); - } else { - streamedResponse = await request.send(); - } + // if (httpClient != null) { + // streamedResponse = await httpClient!.send(request); + // } else { + // streamedResponse = await request.send(); + // } + streamedResponse = httpClient != null + ? await httpClient!.send(request) + : await request.send(); + return _handleResponse(streamedResponse, options); }