fix(storage): remove trailing slash from baseUrl normalization (#1589)

tamanyan · web-flow · commit 636085fe4563 · 2025-10-06T16:44:23.000+03:00
Co-authored-by: tamanyan &lt;tamanyan@users.noreply.github.com&gt;
diff --git a/packages/core/storage-js/src/packages/StorageBucketApi.ts b/packages/core/storage-js/src/packages/StorageBucketApi.ts
@@ -28,7 +28,7 @@ export default class StorageBucketApi {
       }
     }
 
-    this.url = baseUrl.href
+    this.url = baseUrl.href.replace(/\/$/, '')
     this.headers = { ...DEFAULT_HEADERS, ...headers }
     this.fetch = resolveFetch(fetch)
   }
diff --git a/packages/core/storage-js/test/storageBucketApi.test.ts b/packages/core/storage-js/test/storageBucketApi.test.ts
@@ -60,6 +60,7 @@ describe('Bucket API Error Handling', () => {
         'http://localhost:1234/storage/v1',
         'support local host with port without modification',
       ],
+      ['http://localhost:1234', 'http://localhost:1234', 'support local host only with port'],
     ]
 
     urlTestCases.forEach(([inputUrl, expectUrl, description]) => {

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export default class StorageBucketApi {`
`28`	`28`	`}`
`29`	`29`	`}`
`30`	`30`
`31`		`- this.url = baseUrl.href`
	`31`	`+ this.url = baseUrl.href.replace(/\/$/, '')`
`32`	`32`	`this.headers = { ...DEFAULT_HEADERS, ...headers }`
`33`	`33`	`this.fetch = resolveFetch(fetch)`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ describe('Bucket API Error Handling', () => {`
`60`	`60`	`'http://localhost:1234/storage/v1',`
`61`	`61`	`'support local host with port without modification',`
`62`	`62`	`],`
	`63`	`+ ['http://localhost:1234', 'http://localhost:1234', 'support local host only with port'],`
`63`	`64`	`]`
`64`	`65`
`65`	`66`	`urlTestCases.forEach(([inputUrl, expectUrl, description]) => {`