2.49.9 breaks application code on Vercel (error 500)

[wiesson]

Bug report

Describe the bug

    at (../../../../../node_modules/.pnpm/ws@8.18.2/node_modules/ws/browser.js:4:8)
    at (../../../../../node_modules/.pnpm/@supabase+realtime-js@2.11.9/node_modules/@supabase/realtime-js/src/RealtimeClient.ts:222:20)
    at (../../../../../node_modules/.pnpm/@supabase+realtime-js@2.11.9/node_modules/@supabase/realtime-js/src/RealtimeChannel.ts:218:18)

and the app errors with status 500

To Reproduce

Adding later

Expected behavior

I have updated from 2.49.8

Screenshots

If applicable, add screenshots to help explain your problem.

System information

• Version of supabase-js: [e.g. 2.49.9]
• Version of Node.js: [e.g. 22.X] (vercel)

[grdsdev]

Hi @wiesson thank you for reporting the issue, we're working on fix for it, would be great if you could try out the version "@supabase/supabase-js": "2.49.9-next.3" and confirm if that fixed it for you.

Thanks.

[wiesson]

I just deployed a version with "@supabase/supabase-js": "2.49.9-next.3", but I have the same error.

Error: ws does not work in the browser. Browser clients must use the native WebSocket object
    at (../../../../../node_modules/.pnpm/ws@8.18.2/node_modules/ws/browser.js:4:8)
    at (../../../../../node_modules/.pnpm/@supabase+realtime-js@2.11.10-next.1/node_modules/@supabase/realtime-js/src/RealtimeClient.ts:222:20)
    at (../../../../../node_modules/.pnpm/@supabase+realtime-js@2.11.10-next.1/node_modules/@supabase/realtime-js/src/RealtimeChannel.ts:218:18)

It works with 2.49.8, so I'm not sure if I'm supposed to change sth

[grdsdev]

@wiesson can you check with the latest version of supabase-js?

[thisislvca]

Hey! Seeing this error now:

../../node_modules/.pnpm/@supabase+realtime-js@2.11.10/node_modules/@supabase/realtime-js/dist/main/RealtimeClient.js
Critical dependency: the request of a dependency is an expression

[filipecabaco]

are you able to provide some example code so we can replica the issue?

also reopening this issue

[thisislvca]

Will try to create a repro when I get back home later. Here are some additional logs & details in the meantime:

../../node_modules/.pnpm/@supabase+realtime-js@2.11.10/node_modules/@supabase/realtime-js/dist/main/RealtimeClient.js
Critical dependency: the request of a dependency is an expression

Import trace for requested module:
../../node_modules/.pnpm/@supabase+realtime-js@2.11.10/node_modules/@supabase/realtime-js/dist/main/RealtimeClient.js
../../node_modules/.pnpm/@supabase+realtime-js@2.11.10/node_modules/@supabase/realtime-js/dist/main/index.js
../../node_modules/.pnpm/@supabase+supabase-js@2.49.10/node_modules/@supabase/supabase-js/dist/module/index.js
../../node_modules/.pnpm/@supabase+ssr@0.6.1_@supabase+supabase-js@2.49.10/node_modules/@supabase/ssr/dist/module/createBrowserClient.js
../../node_modules/.pnpm/@supabase+ssr@0.6.1_@supabase+supabase-js@2.49.10/node_modules/@supabase/ssr/dist/module/index.js
./src/lib/supabase/server.ts

Actually now that I look at the import trace it looks like the ssr module is using createBrowserClient under the hood, even for the server client. Here's my supabase/server.ts (copied straight from the docs).

import 'server-only';

import { createServerClient } from '@supabase/ssr';
import type { Database } from 'common/types/database';
import { cookies } from 'next/headers';

export function createClient() {
  const cookieStore = cookies();

  return createServerClient<Database>(
    process.env.NEXT_PUBLIC_SUPABASE_URL!,
    process.env.NEXT_PUBLIC_SUPABASE_ANON_KEY!,
    {
      cookies: {
        getAll() {
          return cookieStore.getAll();
        },
        setAll(cookiesToSet) {
          try {
            cookiesToSet.forEach(({ name, value, options }) => cookieStore.set(name, value, options));
          } catch {
            // The `setAll` method was called from a Server Component.
            // This can be ignored if you have middleware refreshing
            // user sessions.
          }
        },
      },
    },
  );
}

[thisislvca]

OK so the repro is literally the official nextjs template: npx create-next-app -e with-supabase.

#1442 might also be related.

[wiesson]

Error: ws does not work in the browser. Browser clients must use the native WebSocket object
    at (../../../../../node_modules/.pnpm/ws@8.18.2/node_modules/ws/browser.js:4:8)
    at (../../../../../node_modules/.pnpm/@supabase+realtime-js@2.11.10/node_modules/@supabase/realtime-js/src/RealtimeClient.ts:222:20)
    at (../../../../../node_modules/.pnpm/@supabase+realtime-js@2.11.10/node_modules/@supabase/realtime-js/src/RealtimeChannel.ts:218:18)

Still the same error, is 2.11.10 the correct version to test with?

[thisislvca]

Yeah, it's the latest version. Honestly, I kinda expected this issue to get more attention, considering it breaks builds...

Edit: it actually doesn't break builds, it compiles with warnings

[wiesson]

Edit: it actually doesn't break builds, it compiles with warnings

So true! I've updated the title. I quickly created this so I wouldn't forget to do it