Skip to content

Conversation

@mandarini
Copy link
Contributor

Problem

  • Every time dependabot updated package-lock.json, it used npm@10 which changed the lock file
  • Every time publish.yml runs, it uses npm@latest (now 11) so that we can use trusted publishing. This means that it gets diffs in the lock file.

Solution

  • Add workflow to auto-regenerate lockfile on Dependabot PRs with npm@latest
  • Fixes recurring CI failures in publish.yml caused by npm version mismatch (Dependabot uses npm 10, publish uses npm 11)

@mandarini mandarini requested review from a team as code owners December 5, 2025 11:35
@mandarini mandarini requested a review from staaldraad December 5, 2025 11:36
@mandarini mandarini self-assigned this Dec 5, 2025
@coveralls
Copy link

coveralls commented Dec 5, 2025

Coverage Status

coverage: 80.691% (-0.5%) from 81.176%
when pulling b9da960 on fix/dependabot-and-lock
into 87e19a3 on master.

Copy link
Member

@staaldraad staaldraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

booooo dependabot 👎🏼
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#package-ecosystem-
states "supported versions: v7,v8,v9,v10" - wish this was configurable through the dependabot.yml

@mandarini
Copy link
Contributor Author

You can specify npm version with renovate I think. But it's ok, I hope this fix fixes the issue. :(

@mandarini mandarini merged commit 21e1008 into master Dec 5, 2025
30 checks passed
@mandarini mandarini deleted the fix/dependabot-and-lock branch December 5, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants